-
Notifications
You must be signed in to change notification settings - Fork 5
Add support for NPX 2.0 single-shank probes #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d3728f0 to
b3f986a
Compare
|
Before merging, make sure that the question of channel numbers is answered; there are differences in the documentation, between the given equations and the spreadsheet with the channel numbers for each electrode. We want to make sure that we have the correct channel map before adding this functionality. |
|
Channel mapping is now corrected, as per confirmed from Josh and Jan. The documentation contains the wrong equations, but the electrode channel mapping spreadsheet has the correct values; the equations now implemented return the correct channel number for each electrode, same as Neuropixels-PXI plugin. |
- This is to match the electrode channel mapping spreadsheet, which has the correct values; the documentation contains the wrong equations, which were originally used
c078b87 to
ccfb833
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some pretty strong anti patterns in here. I would take a look at those and more broadly review your work to make sure that your following OOP best practices.
From a UX perspective, its good.
OpenEphys.Onix1.Design/NeuropixelsV2eChannelConfigurationDialog.cs
Outdated
Show resolved
Hide resolved
OpenEphys.Onix1.Design/NeuropixelsV2eChannelConfigurationDialog.cs
Outdated
Show resolved
Hide resolved
…sses to follow best practices
This PR supersedes #493.
Adding support for single-shank Neuropixels 2.0 probes, with the additional functionality of allowing the user to change the probe type in the GUI.
The text above is now outdated, with the most recent commits there is now a non-browsable, non-externalizable property that is used to handle serialization, leveraging the attributes to automatically add the type; this is called
ConfigurationA/B. Additionally, the originalProbeConfigurationA/Bproperties are not serialized, but they are deserialized into a quad-shank probe configuration, allowing for backward compatibility.@anjaldoshi We do not have any single-shank probes to test with, could you build this branch and run some recordings with a single-shank probe to make sure it records data correctly?
Fixes #446