chore(inspect): fix pre commit and GHA #3084
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a pre-commit configuration file for the /application folder to enable automated code quality checks for both backend (Python) and frontend (Node.js) code. The configuration is scoped specifically to the application directory to avoid conflicts with the root-level anomalib pre-commit configuration.
Key changes:
- Adds
.pre-commit-config.yamlwith hooks for Python (Ruff, mypy) and UI (Prettier, ESLint) tooling - Configures version pins matching application dependencies (Ruff v0.11.2, mypy v1.17.0, Node 24.2.0)
- Includes markdown linting for documentation consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maxxgx
force-pushed
the
max/pre-commit
branch
from
71c928f to
5303c84
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 24 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 18 out of 31 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maxxgx
force-pushed
the
max/pre-commit
branch
from
73460b9 to
83d349f
Compare
maxxgx
changed the title
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Ma, Xiangxiang <[email protected]>
Signed-off-by: Ma, Xiangxiang <[email protected]>
Signed-off-by: Ma, Xiangxiang <[email protected]>
Signed-off-by: Ma, Xiangxiang <[email protected]>
Signed-off-by: Ma, Xiangxiang <[email protected]>
- Replace custom pre-commit action with j178/prek-action@v1 - Update tox.ini to use prek instead of pre-commit - Remove obsolete custom pre-commit action - Add lock file exclusion to size check - Enables workspace mode for monorepo with multiple pre-commit configs Signed-off-by: Ma, Xiangxiang <[email protected]>
maxxgx
force-pushed
the
max/pre-commit
branch
from
83d349f to
2e9ba51
Compare
maxxgx
requested review from
AlexanderBarabanov,
mramotowski and
rajeshgangireddy
as code owners
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 18 out of 31 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ma, Xiangxiang <[email protected]>
Signed-off-by: Ma, Xiangxiang <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 18 out of 31 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 35 out of 45 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ma, Xiangxiang <[email protected]>
Signed-off-by: Ma, Xiangxiang <[email protected]>
Signed-off-by: Ma, Xiangxiang <[email protected]>
maxxgx
force-pushed
the
max/pre-commit
branch
from
06e3f33 to
d63a89b
Compare
Signed-off-by: Ma, Xiangxiang <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 35 out of 45 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Max Xiang <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 35 out of 45 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maxxgx
merged commit 19a3461
into
open-edge-platform:feature/geti-inspect
* add pre-commit config to application Signed-off-by: Ma, Xiangxiang <[email protected]> * comment Signed-off-by: Ma, Xiangxiang <[email protected]> * use prek Signed-off-by: Ma, Xiangxiang <[email protected]> * fix style Signed-off-by: Ma, Xiangxiang <[email protected]> * geti-inspect as optional dependency for anomalib Signed-off-by: Ma, Xiangxiang <[email protected]> * ci: migrate to prek for workspace mode support - Replace custom pre-commit action with j178/prek-action@v1 - Update tox.ini to use prek instead of pre-commit - Remove obsolete custom pre-commit action - Add lock file exclusion to size check - Enables workspace mode for monorepo with multiple pre-commit configs Signed-off-by: Ma, Xiangxiang <[email protected]> * update uv lock Signed-off-by: Ma, Xiangxiang <[email protected]> * comment Signed-off-by: Ma, Xiangxiang <[email protected]> * fix style Signed-off-by: Ma, Xiangxiang <[email protected]> * fix style Signed-off-by: Ma, Xiangxiang <[email protected]> * fix style Signed-off-by: Ma, Xiangxiang <[email protected]> * add backend unit tests GHA Signed-off-by: Ma, Xiangxiang <[email protected]> * Update application/backend/src/entities/video_stream.py Co-authored-by: Copilot <[email protected]> Signed-off-by: Max Xiang <[email protected]> --------- Signed-off-by: Ma, Xiangxiang <[email protected]> Signed-off-by: Max Xiang <[email protected]> Co-authored-by: Copilot <[email protected]>
4 participants
📝 Description
Add pre-commit config in
/applicationfolder.Switch from
pre-committo prek.Add backend unit test GHA
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.