Remove Gym environments, migrate remaining code to gymnasium #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly migrating them to Gymnasium would be quite some work. They were anyway mostly meant as examples and not really used anywhere as far as I now. So I think it's better to just remove them from this package. If someone actually still needs them, I would suggest to rather move them to a separate repo and maintain them there.
- Change all imports of gym to use gymnasium instead. - `env.reset()` now returns a tuple of observation and info. - Instead of `done`, `step()` now returns `terminated, truncated`. - Update dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since gym is not working anymore with recent Python versions, finally migrate the package to gymnasium.
Since migrating the environments contained in this package would be quite some work, simply remove them instead.
They were anyway mostly meant as examples and not really used anywhere as far as I now.
If someone actually still needs them, I would suggest to rather move them to a separate repo and maintain them there.
Resolves #115.
How I Tested
Unit tests.