[TDX] Added Intel TDX support to docsum helm charts #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksandowi
force-pushed
the
docsum-with-tdx
branch
2 times, most recently
from
1d5cdaa to
e7f14db
Compare
JakubLedworowski
suggested changes
Feb 19, 2025
There was a problem hiding this comment.
The implementation lacks changes for docsum-ui. Also tgi and llm-uservice are already enabled.
Please fix the following:
- fix description accordingly to what new component is enabled,
- correct the formatting of the PR description to match the suggested default format,
- fix the sign-off to have only one correct entry with valid email address.
helm-charts/docsum/README.md
Outdated
| # helm install docsum docsum --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN} --values docsum/gaudi-tgi-values.yaml ... | ||
| # To use Gaudi device with vLLM | ||
| # helm install docsum docsum --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN} --values docsum/gaudi-vllm-values.yaml .. | ||
| # To run chatqna with Intel TDX feature |
helm-charts/docsum/README.md
Outdated
| # To use Gaudi device with vLLM | ||
| # helm install docsum docsum --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN} --values docsum/gaudi-vllm-values.yaml .. | ||
| # To run chatqna with Intel TDX feature | ||
| # helm install docsum docsum --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN} --set tgi.LLM_MODEL_ID=${MODELNAME} --set docsum.tdxEnabled=true --set docsum.resources.limits.memory=1Gi --set docsum-ui.tdxEnabled=true --set docsum-ui.resources.limits.memory=2Gi --set llm-uservice.tdxEnabled=true --set llm-uservice.resources.limits.memory=4Gi --set tgi.tdxEnabled=true --set tgi.resources.limits.memory=80Gi --set whisper.tdxEnabled=true --set whisper.resources.limits.memory=13Gi |
There was a problem hiding this comment.
docsum-ui not enabled
There was a problem hiding this comment.
It is with this line:
--set docsum-ui.tdxEnabled=true --set docsum-ui.resources.limits.memory=2Gi
…n docsum README.md Signed-off-by: Krzysztof Sandowicz <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Krzysztof Sandowicz <[email protected]>
Signed-off-by: Krzysztof Sandowicz <[email protected]>
ksandowi
force-pushed
the
docsum-with-tdx
branch
from
989860d to
232981f
Compare
JakubLedworowski
approved these changes
Feb 19, 2025
Signed-off-by: Krzysztof Sandowicz <[email protected]>
JakubLedworowski
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an extension to #799 with Intel TDX support enabled for all docsum microservices.
Subcharts enabled to be run with Intel TDX:
Issues
n/a
Type of change
Dependencies
n/a
Tests
Tested the deployment of docsum example on the running cluster without and with Intel TDX for: