Handle Fixnum and Bignum being merged into Integer in Ruby 2.4 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that Paggio doesn't load in versions of Ruby since 2.4. When monkey-patching numeric classes to handle CSS unit calculations it
raises when it encountersFixnumwhich no longer exists since Ruby 2.4.0.I'm not sure whether the Travis CI or Github workflows are being honoured because Travis CI doesn't have versions after 2.4 so this is the only place specs should pass, but the latest commit references the Github workflow and all versions there are after 2.4 so it seems the goal is not to support pre-2.4 Rubies anymore. So I've added the major versions to both.
In case the goal is to support older and newer Ruby versions I put a conditional to only patch the correct classes. My recommendation is to release a new version, and set the gemspec to require at least Ruby 2.4 and do away with testing the older versions. I didn't want to presume and do it that, but let me know and I can make that change.