-
Notifications
You must be signed in to change notification settings - Fork 107
add zoom translation space in FOV space #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
add zoom translation space in FOV space #543
Conversation
Am I understanding this correctly when I assume it is meant as follows:
Is this correct? Not sure why the range need to be 0 to INF, since 0 to 1 should suffice if we only want to zoom in? The function will not support any movement in pan- or tilt-spaces? |
You forgot the inverse. If you zoom, it would be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly like the FOV suffix more than the existing Fov, but we can't change the existing one. Hence the suggestion to adapt.
<para>The Zoom Translation Space in FOV is defined as follows: <footnote xml:id="__FN17__"><para>The proposed minimum value in range for this relative zoom space is 0 to allow reducing the current zoom.</para></footnote></para> | ||
<programlisting><![CDATA[<tt:RelativeZoomTranslationSpace> | ||
<tt:SpaceURI> | ||
http://www.onvif.org/ver10/tptz/ZoomSpaces/TranslationSpaceFOV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specification is fine. However I suggest to align the URI to the existing PT space http://www.onvif.org/ver10/tptz/PanTiltSpaces/TranslationSpaceFov with trailing lower case 'ov':
http://www.onvif.org/ver10/tptz/ZoomSpaces/TranslationSpaceFov
This PR adds to Annex A a new space titled "Zoom Translation space in FOV". That new zoom space explains the concept of relative zoom translation space in graphical user interfaces for ptz cameras in relation to it's current FOV.