Skip to content

add zoom translation space in FOV space #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

mfournier-genetec
Copy link

This PR adds to Annex A a new space titled "Zoom Translation space in FOV". That new zoom space explains the concept of relative zoom translation space in graphical user interfaces for ptz cameras in relation to it's current FOV.

@Ekmansoft
Copy link
Contributor

Am I understanding this correctly when I assume it is meant as follows:

  1. We want to add a function that allows us to zoom in relative to the current zoom setting.
  2. If we are using 1280x720 resolution and want to zoom in by doubling the focal length the value set would be 640/1280=0.5?
  3. We would thus set TranslationSpace to 0.5.
  4. We should zoom in and decrease FOV to half, and increase focal length?

Is this correct?

Not sure why the range need to be 0 to INF, since 0 to 1 should suffice if we only want to zoom in?

The function will not support any movement in pan- or tilt-spaces?

@jflevesque-genetec
Copy link
Contributor

Am I understanding this correctly when I assume it is meant as follows:

  1. We want to add a function that allows us to zoom in relative to the current zoom setting.
  2. If we are using 1280x720 resolution and want to zoom in by doubling the focal length the value set would be 640/1280=0.5?
  3. We would thus set TranslationSpace to 0.5.
  4. We should zoom in and decrease FOV to half, and increase focal length?

Is this correct?

Not sure why the range need to be 0 to INF, since 0 to 1 should suffice if we only want to zoom in?

The function will not support any movement in pan- or tilt-spaces?

You forgot the inverse. If you zoom, it would be 1 / (640 / 1280) = 2

Copy link
Contributor

@kieran242 kieran242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes.

Copy link
Member

@HansBusch HansBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly like the FOV suffix more than the existing Fov, but we can't change the existing one. Hence the suggestion to adapt.

<para>The Zoom Translation Space in FOV is defined as follows: <footnote xml:id="__FN17__"><para>The proposed minimum value in range for this relative zoom space is 0 to allow reducing the current zoom.</para></footnote></para>
<programlisting><![CDATA[<tt:RelativeZoomTranslationSpace>
<tt:SpaceURI>
http://www.onvif.org/ver10/tptz/ZoomSpaces/TranslationSpaceFOV
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specification is fine. However I suggest to align the URI to the existing PT space http://www.onvif.org/ver10/tptz/PanTiltSpaces/TranslationSpaceFov with trailing lower case 'ov':

http://www.onvif.org/ver10/tptz/ZoomSpaces/TranslationSpaceFov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants