API Proposal: Achievements API #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalAmuyal
requested changes
Mar 19, 2018
Collaborator
TalAmuyal
left a comment
TalAmuyal
left a comment
There was a problem hiding this comment.
Shouldn't goals be completable as well?
src/index.ts
Outdated
| goals: AchievementGoalDefinition[] | ||
| } | ||
|
|
||
| export interface AchievementGoalDefinition { |
Collaborator
There was a problem hiding this comment.
Since AchievementDefinition and AchievementGoalDefinition are under Achievement, I think that the common prefix can be safely omitted.
Also, both end with Definition which is redundant too.
How about Definition and goal respectively?
Member
Author
There was a problem hiding this comment.
Ah ya, good catch - I like that better for sure! Updating now.
Collaborator
|
Trying my power as a reviewer 🙃 |
Member
Author
|
Thanks for looking at it, @TalAmuyal ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.