[Experiment feature] [engine] [compile] use bytecode in execution #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onheap
changed the title
onheap
commented
Jul 23, 2022
| size = 3000000 | ||
| level = 53 | ||
| size = 10000000 | ||
| level = 17 |
There was a problem hiding this comment.
Because we use int16 as the type of the slice index, and the length of the bytecode is 8 times the length of the nodes. so the length (or the complexity) of the expression is reduced.
https://github.com/larry618/eval/blob/2d5ee1141e64bf9378c6730bf1eae99811ba1fa6/compile.go#L144-L153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the structure of the
Expr, Adding a new fieldbytecodewhich is a slice of int16.The idea is to flat the fields of
nodeinto four int16s, and store its in the int16 slice, please refer the code snippet below for details.https://github.com/larry618/eval/blob/2d5ee1141e64bf9378c6730bf1eae99811ba1fa6/compile.go#L453-L472
Benchmark testing
Ideally, this change might improve the performance of the expression evaluation. However, based on the Benchmark testing, this change does not improve the performance of the evaluation, but introduces the additional complexity. Therefore, this PR should not be merged.
Test Plan
it's still working in progress, the debug node has not been supported yet.
Reviewers
@larry618