Don't process scheduled transactions during epoch transitions #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahannan
commented
Nov 3, 2025
| // or expensive operations | ||
| // We don't skip if it is running in a test environment, | ||
| // so we check automaticRewardsEnabled() because it is only true on testnet and mainnet. | ||
| if FlowEpoch.isPhaseTransition() && FlowEpoch.automaticRewardsEnabled() { |
Member
Author
There was a problem hiding this comment.
I want to skip this check if it is on the emulator because epochs don't run on the emulator. Is checking automatic rewards enabled an okay way to do that? I assume that it is only enabled on testnet and mainnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #527
Since epoch transitions already take a lot of computation, we shouldn't process scheduled transactions in the same block that epoch transitions are occurring.
Processing always happens before the epoch heartbeat, so we can make all the same checks that the epoch contract makes.
Adds a utility function to
FlowEpochto indicate if a phase transition is occurring so other system contracts can potentially use it in the future.