Mirror intel/llvm commits #2791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer impl use `char*` pointer for `Ptr` and `HostPtr`, but that will confuse the logger and make it consider those as string and try to print them as string, which will result in SEGV.
This test recently started failing since the runner had a fresh install, disabling until the issue is resolved. See intel/llvm#19033.
Reverts intel/llvm#18962 This patch likely caused these UR CTS failures: https://github.com/intel/llvm/actions/runs/15727687366/job/44323147798?pr=19035 > urCommandBufferAppendKernelLaunchExpTest.DuplicateSyncPoint/UR_BACKEND_LEVEL_ZERO__Intel_R__oneAPI_Unified_Runtime_over_Level_Zero_V2__Intel_R__Data_Center_GPU_Max_1100_ID0ID____________________ And is also possibly the root cause of intel/llvm#19034
Update UR adapter due to changes in llvm/llvm-project#143901
Buffers mapped with `UR_MAP_FLAG_WRITE_INVALIDATE_REGION` need to copy back to the buffer's device memory when unmapped. The HIP adapter was already doing this, seems like an accidental omission in the CUDA adapter.
Fixing NativeCPU handling of UR_KERNEL_INFO_FUNCTION_NAME. At least these e2e test will pass on NativeCPU with this patch: ``` SYCL/FreeFunctionKernels/id_as_kernel_parameter.cpp SYCL/FreeFunctionKernels/accessor_as_kernel_parameter.cpp SYCL/FreeFunctionKernels/marray_as_kernel_parameter.cpp SYCL/FreeFunctionKernels/range_as_kernel_parameter.cpp SYCL/FreeFunctionKernels/vec_as_kernel_parameter.cpp ```
Optimizes the `enqueue()` function of sycl graphs to bypass the scheduler whenever possible and avoid creating events when not needed. * Refactors the executable graph `enqueue()` to have different paths depending on workload: * The direct path will be used when there are no host-tasks or accessor requirements in the graph and the execution dependencies are considered safe to bypass the scheduler. * The scheduler path will be used when there are requirements in the graph but no host-tasks or, if the execution dependencies require using the scheduler. * The multiple partitions path will be used when the graph contains `host-tasks` which requires scheduling multiple graph partitions. The implementation was also changed to avoid adding unnecessary event dependencies to partition executions and avoiding copying `CGData` when possible. * Extends the changes in intel/llvm#18277 to sycl graphs. This means that no implicit events will be created when using in-order queues and graphs without `host-tasks`. Also updates the handler to only request events from the graph `enqueue()` when they are needed.
Unified Runtime -> intel/llvm Repo Move NoticeInformationThe source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory, The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime. The contribution guide will be updated with new instructions for contributing to Unified Runtime. PR MigrationAll open PRs including this one will be marked with the Should you wish to continue with your PR you will need to migrate it to intel/llvm. If your PR should remain open and not be closed automatically, you can remove the This is an automated comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action