-
Notifications
You must be signed in to change notification settings - Fork 6
Server mode and templated views #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smellsblue
wants to merge
58
commits into
master
Choose a base branch
from
server-mode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
e2084a9
Log incoming requests along with request duration
smellsblue 0abaa87
Create new index that does nothing and replace html templates with mu…
smellsblue 442d0b3
Convert ServerNotReadyQuery to use mustache and add memory details to…
smellsblue 65bf758
Convert AllClassesQuery into a Mustache template
smellsblue d7aa7db
Convert AllRootsQuery to Mustache
smellsblue 0b20664
Refactor AllClassesQuery to use view models, and move the newer metho…
smellsblue dadc277
Refactor MemoryUsageDetails to be a view model
smellsblue 93b4c96
Convert over the InstancesCountQuery
smellsblue 497b08f
Break out server to it's own
smellsblue 16af180
Support loading a dump while the server is running
smellsblue 57f106e
Drop the dots in favor of a log that will play well with request log …
smellsblue 4d28180
Allow unloading a dump
smellsblue fcc0f40
Fix up parameter parsing
smellsblue fd6812f
Add a comment
smellsblue 3f7e5d4
Disallow dumps outside the configured heaps directory, except when it…
smellsblue 6b95192
Speed up histogram pages by pre-caching the total instance size
smellsblue d6cb432
Parallelize the caching of histograms
smellsblue aaf0dc9
Drop most loading output since the server shows an easier to read pro…
smellsblue b0a5a11
Convert InstancesQuery to mustache view
smellsblue 7d573f9
Mustachify the ClassQuery
smellsblue 2c1572f
Mustachify ObjectQuery
smellsblue 60bde8a
Use divs and paragraph tags instead of break tags
smellsblue 6b5e274
Mustachify the error page
smellsblue 45e4fa9
Reduce routes by pulling out a parameter
smellsblue 990790f
Consolidate instances count query to 1 route
smellsblue 105be1a
Consolidate instances of the instance query to 1 route
smellsblue 62df021
Mustachify RootsQuery
smellsblue da248f3
Reduce routes by pulling out parameter and fix bug with missing objec…
smellsblue 702ec9e
Remove some no longer needed methods
smellsblue fb9e99e
Mustachify FinalizerObjectsQuery
smellsblue 501fab8
Mustachify ReachableQuery
smellsblue 76a7604
Mustachify RootStackQuery and drop some no longer used methods
smellsblue d9135e0
Convert HistogramQuery to a mustache query handler
smellsblue e43908f
Convert FinalizerSummaryQuery to a MustacheQuery
smellsblue 2c8647c
Move the OQLEngine around a bit
smellsblue e4ce3f2
Convert OQLEngine to return a Stream rather than using a visitor
smellsblue f256335
Mustachify OQLQuery
smellsblue efd9c5e
Mustachify RefsByTypeQuery
smellsblue a2f2b0f
Mustachify DebugQuery and remove a bunch of no longer needed methods
smellsblue 6df358f
Peer review feedback
smellsblue a4d7698
Convert to a more standard maven project, but keep ant working for no…
smellsblue 0297721
Start some tests and add some more peer review feedback
smellsblue 03091a2
Some peer review feedback and some other changes
smellsblue 126278c
Synchornize access to loadingSnapshot
smellsblue c39044c
Peer review feedback: suppliers for total instance size cache
smellsblue f0e5c97
Some more peer review feedback
smellsblue aeb5ea7
Peer review feedback: return Stream for JavaClass#getInstances
smellsblue d6164bf
Peer review feedback: use Stopwatch for keeping track of elapsed time
smellsblue 4b9e156
Peer review feedback: first pass at adding @ViewGetter annotation for…
smellsblue 8453bfb
Peer review feedback: add the rest of the @ViewGetter annotations
smellsblue 89d8d8c
Peer review feedback: use method references. Also ensure reader is cl…
smellsblue 00771ff
Peer review feedback: use memoize and rename method to a more appropr…
smellsblue ae10087
Peer review feedback: memoize the model
smellsblue 718ec1c
Peer review feedback: drop array hack and have visitor return the res…
smellsblue 4598771
Peer review feedback: drop unnecessary null checks
smellsblue 3ccb31c
Peer review feedback: convert all referer to referrer
smellsblue 51ed09c
Peer review feedback: use Duration class to simplify formatTime
smellsblue 213335d
Peer review feedback: simplify thread local setup and remove a bunch …
smellsblue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
148 changes: 0 additions & 148 deletions
148
src/com/sun/tools/hat/internal/server/AllClassesQuery.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"test".equals(scope)is mildly deprecated, because it's hard for humans to decipher the intent. I tend to prefer to signal my intent directly:scopecan contain null as a valid value, useObjects.equals(scope, "test").scope.equals("test").