Implement ParameterAttributeCollector

[staabm]

implement the necessary plumbing which allows us to find targets for attributes on method parameters

ports the implementation from ondrejmirtes#2 into this upstream repo

[olvlvl]

Hi @staabm, thank you for your contribution. What would the use case for this feature be?

[staabm]

Hey,

we use this implementation to make the lib work for PHPStan DI-Container configuration.
In this particular case we use it to wire parameters based on attributes.

see e.g. https://github.com/phpstan/phpstan-src/pull/4042/files#diff-3f4dd13f82480303d89c9bf92a5f81a457113ac25e44f7604f89503f210a18b4L27

[olvlvl]

I'm considering the naming "methodAttributes". The class is ReflectionAttribute, I think we should match the naming. Would it clash with other parameter types?

Also, please rebase you're branch. I've made some changes to decouple the collector from IOInterface.

[olvlvl]

Let's remove this one, it's already in the signature.

[olvlvl]

Let's split this over multiple lines.

Suggested change

	private function collectMethodAndParameterAttributes(string $class, \ReflectionMethod $methodReflection, array &$methodAttributes, array &$methodParameterAttributes): void
	private function collectMethodAndParameterAttributes(
	string $class,
	\ReflectionMethod $methodReflection,
	array &$methodAttributes,
	array &$methodParameterAttributes
	): void {

[olvlvl]

Also, I'd like it better if we were not using references… but I can live with it.

[olvlvl]

Suggested change

	if ($parameterAttributes !== []) {
	if ($parameterAttributes) {

Simpler to read.

[olvlvl]

Let's split this one.

Suggested change

	$this->state[$class] = [ time(), $classAttributes, $methodAttributes, $propertyAttributes, $methodParameterAttributes ];
	$this->state[$class] = [
	time(),
	$classAttributes,
	$methodAttributes,
	$propertyAttributes,
	$methodParameterAttributes,
	];

[olvlvl]

Unused imports.

Suggested change

	use PhpParser\Node;
	use PhpParser\Node\Stmt\ClassLike;
	use PhpParser\NodeTraverser;
	use PhpParser\NodeVisitorAbstract;
	use PhpParser\Parser;

[olvlvl]

We initialize the variable here, but it's used much later. Besides, the variable is only used once, we could do without.

Suggested change

$attributes = $parameter->getAttributes();

[olvlvl]

Suggested change

	foreach ($attributes as $attribute) {
	foreach ($parameter->getAttributes() as $attribute) {

[olvlvl]

We can use promoted properties here:

Suggested change

	{
	public string $label;
	public function __construct(
	string $label = ''
	) {
	$this->label = $label;
	}
	public function __construct(
	public string $label = ''
	) {
	}

[olvlvl]

We can use promoted properties here:

Suggested change

	public string $label;
	public string $moreData;
	public function __construct(
	string $label = '',
	string $moreData = ''
	) {
	$this->label = $label;
	$this->moreData = $moreData;
	}
	public function __construct(
	public string $label = '',
	public string $moreData = ''
	) {
	}

[olvlvl]

I think we should make it more apparent in the tests that we don't want this attribute to be collected; for example, with a $this->assertNotExists().

[ondrejmirtes]

By the way, I just wanted to show my appreciation for this package: it's awesome! It enabled me to use attributes in PHPStan to trim down the config files. I plan to publish a community update about this, but here's already an issue with some description and links to diffs what it allowed me to do: nette/di#324

I can also keep PHP 7.4 support because the attributes file is baked into the PHAR, so runtime inspection is not needed :)

[olvlvl]

I opened another PR to complete the changes. I tested the branch on a few projects with success.

@staabm @ondrejmirtes Could you test the changes with your project? Careful, I renamed a few things. You'll have to use the findTargetParameters() method now.

#37

[staabm]

implemented via #37