Skip to content
This repository was archived by the owner on Aug 23, 2021. It is now read-only.

Conversation

Covariants
Copy link

Splicemachine team.

@apavlo apavlo changed the title Pull Request for Database Extra credit Project SpliceMachine Support Dec 16, 2017
Copy link
Member

@apavlo apavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested changes.

oltpbench.iml Outdated
@@ -0,0 +1,70 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please expunge this file from your commit history and rebase.

<artifactId>ojdbc14</artifactId>
<version>10.2.0.1.0</version>
</dependency>
<dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dedcode @dvanaken I don't think we want to include all these things, right?

orlnPrepStmt.setTimestamp(idx++, order_line.ol_delivery_d);
} else {
orlnPrepStmt.setNull(idx++, 0);
orlnPrepStmt.setTimestamp(idx++, null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix your formatting. This also looks to be a SpliceMachine specific change. Why doesn't "0" work?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of forget the complaining message. I just keep receiving the complaining message if I do not change it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants