-
Notifications
You must be signed in to change notification settings - Fork 263
SpliceMachine Support #185
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the requested changes.
oltpbench.iml
Outdated
@@ -0,0 +1,70 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please expunge this file from your commit history and rebase.
<artifactId>ojdbc14</artifactId> | ||
<version>10.2.0.1.0</version> | ||
</dependency> | ||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
orlnPrepStmt.setTimestamp(idx++, order_line.ol_delivery_d); | ||
} else { | ||
orlnPrepStmt.setNull(idx++, 0); | ||
orlnPrepStmt.setTimestamp(idx++, null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix your formatting. This also looks to be a SpliceMachine specific change. Why doesn't "0" work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of forget the complaining message. I just keep receiving the complaining message if I do not change it.
Splicemachine team.