Include link to original source of repo #281
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repo is often used in examples, where it's copied wholesale or inserted via submodule into another repository. If a user wants to modify the JS app's actual source, rather than just the local copy, they will benefit from having the link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo is often used in examples, where it's copied wholesale or inserted via submodule into another repository.
If a user wants to modify the JS app's actual source, rather than just the local copy, they will benefit from having the link.
I discovered this omission when reviewing an example repo that uses this app, https://github.com/noinarisak/okta-terraform-hub-spoke-oidc, and I had to go ask the author about where the React sample came from rather than just seeing it in the readme.