Migrate to react-router v6 #143
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuowu
reviewed
Nov 2, 2020
|
Let's wait on the official |
denysoblohin-okta
force-pushed
the
OKTA-318565-react-router-6
branch
from
c30c9e5 to
7a25732
Compare
denysoblohin-okta
force-pushed
the
OKTA-318565-react-router-6
branch
from
7a25732 to
6ae4878
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-router v6 introduces breaking changes
<Route>s should be inside<Routes><Route exact>removed, so need to use*inpathif it's not exact<Route component>replaced to<Route element>Issue: https://github.com/okta/okta-oidc-js/issues/853
Internal ref: https://oktainc.atlassian.net/browse/OKTA-318565
PR for
okta-react: okta/okta-react#26Warning! This PR uses
react-router 6.0.0-beta.0and should be revised after stable RR release. Do not merge.