Skip to content
This repository was archived by the owner on Jan 26, 2025. It is now read-only.

Conversation

denysoblohin-okta
Copy link
Contributor

@denysoblohin-okta denysoblohin-okta commented Aug 4, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Customer reports then default authorization for /token endpoint (client_secret_basic) doesn't work for some reason (related to configuration of his network probably) but client_secret_post works.

Issue Number: OKTA-379204

What is the new behavior?

Developer can pass custom options to OpenId Client constructor

Should resolve issue okta/samples-nodejs-express-4#105
by adding

    oidcClientOptions: {
      token_endpoint_auth_method: 'client_secret_post',
    }

in options for ExpressOIDC here: https://github.com/okta/samples-nodejs-express-4/blob/master/common/sample-web-server.js#L31

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

denys.oblohin added 3 commits August 5, 2021 01:38
Add oidcClientOptions
add test
lint fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant