Add require_prompt as an option

[jirian]

All Submissions:

• Have you followed the plugin Contributing guideline?
• Does your code follow the WordPress' coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

This PR adds a "require_prompt" option in the settings. If enabled, it adds the prompt=login parameter to the authentication URL forcing the IdP to show the login form every time, regardless of whether the user checked "Remember Me".

How to test the changes in this Pull Request:

1. Set Require Prompt to true in settings.
2. Check whether &prompt=login gets appended to the authentication URL.

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Adds a "require_prompt" option in the settings. If enabled, it adds the prompt=login parameter to the authentication URL forcing the IdP to show the login form every time, regardless of whether the user checked "Remember Me".

[timnolte]

@jirian have you considered just using the plugin hooks and custom settings features to add this yourself via a Must Use Plugin? I'm not saying that we won't add this feature, however the plugin is very customizable already to add such a feature without needing to modify the plugin code.

[jirian]

@timnolte I have now :), but I still feel that since this is a direct part of the OpenID Connect spec, it should be a part of the plugin itself.

[timnolte]

@jirian excellent! I hadn't taken a look at the spec yet to determine whether this was actually part of the spec or possibly something to a specific IDP. When things seem to be specific to an IDP I'm hesitant to incorporate it directly into the plugin.

It looks like there are failing checks can you double check and run PHPCS to ensure that your code changes meet standards? I think there is something odd going on with PHPStan, I'll check into that.

[jirian]

@timnolte I understand that. Just in case, I wrote a must-use plugin too (https://github.com/jirian/oidc-require-prompt-addon), but this really is a direct part of the spec, not a IdP-specific thing.

I linted the code using phpcs, it should pass the checks now.

[timnolte]

@jirian not sure what's going on with the static analysis. GitHub Actions & local runs on the current dev branch works just fine, but your PR is failing.

[jirian]

@timnolte I'm not sure either, it's reporting the errors on lines that I didn't change at all. I have no clue what is going on.