Skip to content

prov/util: Remove peer rx entry if it's in the unspec_unexp queue #11402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

prov/util: Remove peer rx entry if it's in the unspec_unexp queue #11402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions prov/util/src/util_srx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,14 @@ static void util_free_entry(struct fi_peer_rx_entry *entry)
ofi_buf_free(owner_entry);
}
}

/* If free_entry was called but the addr is still FI_ADDR_UNSPEC, the rx
* entry must be in the unspec_unexp_[msg,tag]_queue. Remove it so that
* the queue does not get corrupted. */
if (entry->addr == FI_ADDR_UNSPEC) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if an fi_trecv is called with FI_ADDR_UNSPEC, the util_rx_entry will be created with addr as FI_ADDR_UNSPEC as well and put in the expected rx queue. Then is this logic still correct? I forgot when free_entry will be called, it's before matching or after, or both

dlist_remove(&util_entry->d_entry);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The braces can be got rid of here.


ofi_buf_free(util_entry);
}

Expand Down