Skip to content

fabtests: Fix message sizes in unexpected_msg test #11399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fabtests: Fix message sizes in unexpected_msg test #11399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions fabtests/functional/unexpected_msg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,14 +234,13 @@ static int exchange_unexp_addr(void)
/*
* Send two messages - first will be matched to FI_ADDR_UNSPEC
* Second will be matched to directed receive after fi_av_insert
* Message size is not important - so send 1 byte messages
*/
ret = ft_post_tx_buf(ep, remote_fi_addr, addrlen, 0, &tx_ctx,
tx_buf, mr_desc, ft_tag);
ret = (int) ft_tx(ep, remote_fi_addr, 1, &tx_ctx);
Copy link
Contributor

@aingerson aingerson Sep 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These both need to stay with the ft_post_tx_buf call which don't wait for the completion. ft_tx waits for it to complete which is going to conflict with the get_tx_comp(2) call on line 249 and make the test hang. The goal here is to post 2 sends and then sync with the other side to ensure that they go to the unexpected queue before the receives are posted.

if (ret)
goto err;

ret = ft_post_tx_buf(ep, remote_fi_addr, addrlen, 0, &tx_ctx,
tx_buf, mr_desc, ft_tag);
ret = (int) ft_tx(ep, remote_fi_addr, 1, &tx_ctx);
if (ret)
goto err;

Expand Down