Skip to content

Conversation

hokolomopo
Copy link
Contributor

Description:

[FIX] charts: fix zoomable scatter chart

The zoomable scatter chart would display a line chart in the "master",
instead of a smaller scatter chart.

[IMP] tests: add zoomable chart plugin tests

The chart runtime generated for the "master" chart of zoomable
charts was actually never properly tested, except indirectly
through unrelated snapshot tests.

[MOV] tests: move zoomable chart tests to a dedicated folder

Task: 5143146

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

The chart runtime generated for the "master" chart of zoomable
charts was actually never properly tested, except indirectly
through unrelated snapshot tests.

Task: 5143146
The zoomable scatter chart would display a line chart in the "master",
instead of a smaller scatter chart.

Task: 5143146
@robodoo
Copy link
Collaborator

robodoo commented Oct 10, 2025

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants