[FIX] Composer: Fix assistant position #7288
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rrahir
force-pushed
the
saas-18.4-fix-assistant-rar
branch
2 times, most recently
from
484fd2b to
f4e54fc
Compare
hokolomopo
reviewed
Oct 15, 2025
Comment on lines
+237
to
+238
| assistantStyle.top = `-3px`; | ||
| assistantStyle.transform = `translate(0, -100%)`; |
There was a problem hiding this comment.
nitpick: there is a space between the composer and the assistant. Maybe it's good enough 🤷
hokolomopo
reviewed
Oct 15, 2025
| "max-height": `130px`, | ||
| }), | ||
| showAssistant: !isIOS(), // Hide assistant on iOS as it breaks visually | ||
| showAssistant: false, // Hide assistant in small composer as it gets cropped ATM |
There was a problem hiding this comment.
I don't see a task to fix this, am I blind or we do we not care about this ?
There was a problem hiding this comment.
Its on the task description - it's not properly visible due to the html structure because we have several overflow:hidden that we use for other purpose. since it's not usable, its beter to deactivate it and try to reintroduce it as a banner for bottom bar specifically
There was a problem hiding this comment.
Yeah I see why you disabled it, but I didn't find a task to fix it properly in the future
The composer assistant position was updated with the introduction of the mobile mode but there are two issues with it: - the change of CSS rule did not account for cells with the content set on multiple lines - the structure of the bottom bar composer (in mobile mode) still hides the formula assistant This revision reverts the assistant position and simply hides it in mobile. A future work will try to reintroduce it with a modified aspect that suits the mobile interface. Task: 5155838
rrahir
force-pushed
the
saas-18.4-fix-assistant-rar
branch
from
f4e54fc to
0b3dba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The composer assistant position was updated with the introduction of the mobile mode but there are two issues with it:
This revision reverts the assistant position and simply hides it in mobile. A future work will try to reintroduce it with a modified aspect that suits the mobile interface.
Task: 5155838
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist