[FIX] charts: correctly humanize decimal numbers #7287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have an `humanizeNumbers` option for the chart to make large numbers more readable. The option is enabled by default on every chart, but it was not correctly handling decimal numbers. The function was always rounding them to the nearest integer, which does not make sense for small numbers (eg. 0.15 should not be displayed as 0). Task: 5155591
|
|
The `humanizeNumbers` checkbox was missing in the design panels of sunburst, treemap and bar charts. Task: 5155591
anhe-odoo
reviewed
Oct 14, 2025
| static components = { | ||
| ...ChartWithAxisDesignPanel.components, | ||
| Checkbox, | ||
| ChartHumanizeNumbers, |
There was a problem hiding this comment.
Not needed here, it's already in the ChartWithAxisDesignPanel.components :)
| let numberFormat: Format | undefined = format; | ||
| if (Math.abs(numberValue) < 1000) { | ||
| const hasDecimal = numberValue % 1 !== 0; | ||
| numberFormat = !format && hasDecimal ? "0.####" : format; |
There was a problem hiding this comment.
Not sure we need to have 4 decimals, I would have gone to 2, but why not :)
There was a problem hiding this comment.
Ideally it's dependant on the number of digit before the comma (123.4, 12.34, 123.4). And ideally, we should also probably handle the different formats (a formatLargeNumber function, but for small ones)
Not sure it's worth tho, I went with the fast & dumb approach.
hokolomopo
force-pushed
the
19.0-fix-humanize-decimal-numbers-adrm
branch
from
43169df to
cc602b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have an
humanizeNumbersoption for the chart to make large numbers more readable. The option is enabled by default on every chart, but it was not correctly handling decimal numbers. The function was always rounding them to the nearest integer, which does not make sense for small numbers (eg. 0.15 should not be displayed as 0).Task: 5155591
review checklist