Master lock sheet rar #7264
Open
Master lock sheet rar #7264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rrahir
force-pushed
the
master-lock-sheet-rar
branch
6 times, most recently
from
0942103 to
8dd025f
Compare
rrahir
force-pushed
the
master-lock-sheet-rar
branch
3 times, most recently
from
731be9b to
feb52da
Compare
This revisions adds a (naive) protection for the full sheet. The ability to block specific modifications (style, grid structure, etc) is not strictly compatible with our collaborative approach as the server is never aware of the current state of the spreadsheet. Task: 5103728
Currently, a failed dispatch can only be caught be the original caller as it appears in its result. This means that every individual caller needs to handle the dispatch result if needed (see all the `interactiveX` helpers we already added). This works well with specific commands with specific rejections that only concern them (paste, merge, sort), that is if there is a kind of one-to-one relation between the dispatch and a given allowdispatch. Considering the new addition of the `LOCK_SHEET` command, there is no one-to-one relation. Pretty much any core/sheety command can be rejected by the SheetLockPlugin allowDispatch and if we wanted to handle this rejection of command, each dispatch done in the UI should handle the specific command result of a locked sheet, which adds a ton of maintenance. In the past, we already faced that issue and we introduced the `UIActions` inside the plugin to allow the plugins to send a generic signal to the UI which could then be handled. After consideration, the current solution seems too limiting. For each new specific behaviour we want to introduce, we need to add another eventType to the bus, we a limited interface so the plugins cannot have completely random communication with the UI. It works for limited and contextless notifications but that is it. This commit introduces yet a new eventType on the bus that will return failed dispatchResults, with their context of execution (the root command) which will allow every UI component to react as they want to any sort of scenario. Task: 5103728
Components can now react to the model rejecteing specific commands. With this revision, the component BottomBarSheet will capture the commands rejected because the sheet is locked and will trigger a specific animation to catch the user attention if they want to unlock the sheet. Task: 5103728
rrahir
force-pushed
the
master-lock-sheet-rar
branch
from
feb52da to
2c1224f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 5103728
review checklist