[FIX] charts: fix smart chart engine #7249
Closed
+374
−494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
We have a "Smart chart engine" that automatically suggests a chart type and configuration based on the selected data. There were a bunch of issues with it: - some selected columns were sometime missing from the chart definition - the chart created was sometime empty - the order of the selected columns has totally ignored, leading to some strange definitions with a dataset [col1, col3] and labels on col2 - we used a `createBaseChart` helper that casted an object into a `ChartDefinition`, skipping the typing and leading to wrong chart definitions with missing properties. - some rules were strange or inconsistent This commit fixes those issues, making the rules simpler and more consistent, while adding some docstring to explain the desired behavior. Task: 5079093
hokolomopo
force-pushed
the
19.0-fix-smart-chart-engine-adrm
branch
from
c3d8484 to
92d88a7
Compare
pro-odoo
approved these changes
Oct 22, 2025
Comment on lines
+100
to
+107
| /** | ||
| * Builds a chart definition for a single column selection. The logic to detect the chart type is as follows: | ||
| * - If the column contains a single cell, create a scorecard. | ||
| * - If the column type is "percentage", create a pie chart. | ||
| * - If the column type is "text", create a pie chart | ||
| * - If the column type is "date", create a line chart. | ||
| * - Otherwise, create a bar chart. | ||
| */ |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a "Smart chart engine" that automatically suggests a chart type and configuration based on the selected data. There were a bunch of issues with it:
createBaseCharthelper that casted an object into aChartDefinition, skipping the typing and leading to wrong chart definitions with missing properties.This commit fixes those issues, making the rules simpler and more consistent, while adding some docstring to explain the desired behavior.
Task: 5079093
review checklist