Skip to content

[FIX] data validation: handle cell format in auto-complete #6871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jul 29, 2025

Description

The auto complete of data validation showed the raw cell value instead of the formatted value. We should display the formatted value in the auto-complete, but still use the raw value when selecting a proposal.

The same issue was also present in the side panel.

Task: 4865661

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #6804

The auto complete of data validation showed the raw cell value instead
of the formatted value. We should display the formatted value in the
auto-complete, but still use the raw value when selecting a proposal.

The same issue was also present in the side panel.

Task: 4865661
X-original-commit: 3139f26
@robodoo
Copy link
Collaborator

robodoo commented Jul 29, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jul 29, 2025

@hokolomopo @LucasLefevre this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@hokolomopo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Jul 29, 2025
The auto complete of data validation showed the raw cell value instead
of the formatted value. We should display the formatted value in the
auto-complete, but still use the raw value when selecting a proposal.

The same issue was also present in the side panel.

closes #6871

Task: 4865661
X-original-commit: 3139f26
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Adrien Minne (adrm) <[email protected]>
@robodoo robodoo added the 18.5 label Jul 29, 2025
@robodoo robodoo closed this Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants