[FIX] Evaluation: Optimize invalidation of cell depending of spreads #6827
+30
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rrahir
commented
Jul 22, 2025
rrahir
force-pushed
the
18.0-imp-recompute-eval-rar
branch
2 times, most recently
from
38af9dd to
8e6ab30
Compare
Currently, we invalidate all the cells that depend on a spilling formula
during its evaluation. However, some edgecases (like the one described
below) can make the amount of dependant cells explode with a noticeable
amount of redundancy in the cells invalidated.
study case:
- in A1 write `=SPLIT("1 2", " ")`
- in C1, write `=B2`
- autofill these over 1000 columns
- in another sheet, write a VLOOKUP that search in column C of sheet 1
and autofill around 7000 times
-> the evaluation becomes really slow
The example above is problematic because for each cell evaluated in
A1-B1, we will the corresponding C formula along with EVERY cell with a
VLOOKUP, which means the cells with VLOOKUP will be invalidated 500 (#
or rows) times.
It so happens that the invalidation step requires to regroup all the
cells in zones and this step can be costy, especially if repeated
hundreds of times.
This revision captures the cells that need to be invalidated during a
pass of evaluation and invalidates all of them at once to limit the
overhead of regrouping them.
In the aforementioned example, the time to evaluate drops from 6.7 to
2.1 seconds on average (10 runs).
Task: 4954710
rrahir
force-pushed
the
18.0-imp-recompute-eval-rar
branch
from
8e6ab30 to
5426e10
Compare
hokolomopo
reviewed
Jul 24, 2025
| // the result matrices are split in subzones to exclude the array formula position. | ||
| // This avoids to invalidate the topleft position of an array formula | ||
| // and create an infinite loop of self-invalidation | ||
| const boundingboxes = this.positionsToInvalidate |
There was a problem hiding this comment.
Suggested change
| const boundingboxes = this.positionsToInvalidate | |
| const boundingBoxes = this.positionsToInvalidate |
| ) | ||
| .flat(); | ||
| const invalidatedPositions = this.formulaDependencies().getCellsDependingOn(boundingboxes); | ||
| for (const range of this.positionsToInvalidate) { |
There was a problem hiding this comment.
So this removes the top-left cells from the positions to invalidate ... wasn't this already done in the excludeTopLeft above ? I'm a bit confused
| ) | ||
| .flat(); | ||
| const invalidatedPositions = this.formulaDependencies().getCellsDependingOn(boundingboxes); | ||
| for (const range of this.positionsToInvalidate) { |
There was a problem hiding this comment.
So are they ranges or positions ? I feel like we could improve the naming here
| .flat(); | ||
| const invalidatedPositions = this.formulaDependencies().getCellsDependingOn(boundingboxes); | ||
| for (const range of this.positionsToInvalidate) { | ||
| invalidatedPositions.delete({ |
There was a problem hiding this comment.
this is causing the issue @hokolomopo posted on the task chatter.
A1 should be recomputed (because A3 spilled on the zone it depends on), but this line removes it from this.nextPositionsToUpdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we invalidate all the cells that depend on a spilling formula during its evaluation. However, some edgecases (like the one described below) can make the amount of dependant cells explode with a noticeable amount of redundancy in the cells invalidated.
study case:
=SPLIT("1 2", " ")=B2-> the evaluation becomes really slow
The example above is problematic because for each cell evaluated in A1-B1, we will the corresponding C formula along with EVERY cell with a VLOOKUP, which means the cells with VLOOKUP will be invalidated 500 (# or rows) times.
It so happens that the invalidation step requires to regroup all the cells in zones and this step can be costy, especially if repeated hundreds of times.
This revision captures the cells that need to be invalidated during a pass of evaluation and invalidates all of them at once to limit the overhead of regrouping them.
In the aforementioned example, the time to evaluate drops from 6.7 seconds to 2.1 seconds on average.
Task: 4954710
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist