-
Notifications
You must be signed in to change notification settings - Fork 59
[FIX] pivot: support SUM and AVG aggregators for duration fields #6809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d4f22d3
to
4f755c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋
4f755c0
to
0cf015a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the small comment to simplify the component test 👍
tests/pivots/spreadsheet_pivot/spreadsheet_pivot_side_panel.test.ts
Outdated
Show resolved
Hide resolved
tests/pivots/spreadsheet_pivot/spreadsheet_pivot_side_panel.test.ts
Outdated
Show resolved
Hide resolved
Steps to reproduce: - Create a pivot with a duration-formatted column. - Go to the side panel and add the duration field to the Measures section. Before this commit: - Datetime-formatted fields (such as durations) could not be aggregated using SUM or AVG in pivot measures. - This blocked users from summing or averaging durations After this commit: - SUM and AVG aggregators are supported for datetime fields, - Allowing meaningful aggregation of duration values in pivot tables. Task: 4945217
0cf015a
to
7a840fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
robodoo r+
Steps to reproduce: - Create a pivot with a duration-formatted column. - Go to the side panel and add the duration field to the Measures section. Before this commit: - Datetime-formatted fields (such as durations) could not be aggregated using SUM or AVG in pivot measures. - This blocked users from summing or averaging durations After this commit: - SUM and AVG aggregators are supported for datetime fields, - Allowing meaningful aggregation of duration values in pivot tables. closes #6809 Task: 4945217 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Description:
Steps to reproduce:
Current behavior before PR:
be aggregated using SUM or AVG in pivot measures.
Desired behavior after PR is merged:
Task: 4945217
review checklist