[FIX] side_panel: replace side panel instead of stacking it #6783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dhrp-odoo
reviewed
Jul 14, 2025
rmbh-odoo
force-pushed
the
saas-18.4-fix-reopen-sidepanel-from-child-rmbh
branch
2 times, most recently
from
5520e2b to
bb189c5
Compare
rmbh-odoo
changed the title
rmbh-odoo
force-pushed
the
saas-18.4-fix-reopen-sidepanel-from-child-rmbh
branch
from
bb189c5 to
db3faaa
Compare
dhrp-odoo
reviewed
Jul 16, 2025
hokolomopo
reviewed
Jul 22, 2025
src/components/side_panel/pivot/pivot_measure_display_panel/pivot_measure_display_panel.ts
Outdated
Show resolved
Hide resolved
rmbh-odoo
force-pushed
the
saas-18.4-fix-reopen-sidepanel-from-child-rmbh
branch
2 times, most recently
from
988075d to
ec38ef6
Compare
rmbh-odoo
changed the title
rmbh-odoo
force-pushed
the
saas-18.4-fix-reopen-sidepanel-from-child-rmbh
branch
2 times, most recently
from
e148dc3 to
0cf4351
Compare
rrahir
reviewed
Jul 29, 2025
| return; | ||
| } | ||
| const expandMainPanelIfCollapsed = () => { | ||
| if (this.mainPanel?.isCollapsed) { |
There was a problem hiding this comment.
why not expending it whatever happens?
There was a problem hiding this comment.
I considered the same, but found a case where just expanding isn’t enough.
If the user has resized the panel (without collapsing), we shouldn't override it.
So we check if the panel was resized; if not, apply the default size.
I think the current check is better than checking the panel size directly.
REF : sourceLink
What do you think 🤔
There was a problem hiding this comment.
I think i's not that easy to follow what goes on in that panel :p
Indeed it looks necessary :)
Steps to reproduce: - Open the global filter side panel (list of all filters) - Pin the panel - Click on a specific filter to view/edit it Before this commit: - A second side panel was opened instead of replacing the current one - Clicking 'Cancel' on the new panel had no effect - Clicking 'Remove' caused a traceback After this commit: - The new side panel replaces the current one (main or secondary) - The previous panel is restored correctly on 'Cancel' or 'Remove' - If the new panel is already open, we simply close the current one Task: 4911603
rmbh-odoo
force-pushed
the
saas-18.4-fix-reopen-sidepanel-from-child-rmbh
branch
from
0cf4351 to
98b5144
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Steps to reproduce:
Current behavior before PR:
Desired behavior after PR is merged:
Task: 4911603
review checklist