[IMP] accounting_firm: add features for AML, ID and CSAM #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
frva-odoo
force-pushed
the
19.0-accounting-firm-id-aml-frva
branch
2 times, most recently
from
c59dee0 to
67b2b6e
Compare
frva-odoo
force-pushed
the
19.0-accounting-firm-id-aml-frva
branch
from
67b2b6e to
0d5f42e
Compare
vava-odoo
reviewed
Oct 21, 2025
| <function model="base.automation" name="unlink"> | ||
| <value model="base.automation" eval="obj().search([('id', 'in', [ref('accounting_firm.base_automation_1'), ref('accounting_firm.base_automation_2')])]).ids"/> | ||
| </function> | ||
| <function name="button_immediate_uninstall" model="ir.module.module" eval="[ref('base.module_web_studio', raise_if_not_found=False)]"/> |
There was a problem hiding this comment.
Please remove the installation triggered in demo/base_automation.xml as well
By the way, don't we need to edit those server actions?
| "views": [[False, "form"]], | ||
| "target": "new", | ||
| "context": { | ||
| "default_folder_id": 2, |
There was a problem hiding this comment.
You probably want to use a reference here instead of an hardcoded id
| "target": "new", | ||
| "context": { | ||
| "default_folder_id": 2, | ||
| "default_res_id": record.id or False, |
There was a problem hiding this comment.
False is the fallback if there is none. Or did I miss something?
Suggested change
| "default_res_id": record.id or False, | |
| "default_res_id": record.id, |
| <field name="state">code</field> | ||
| <field name="name">Update Owner ID</field> | ||
| <field name="code"><![CDATA[ | ||
| for ubo in records.filtered('attachment_ids'): |
There was a problem hiding this comment.
Isn't it enough to hide the button on the form if there is no attachment?
| ubo.holder_id['x_id_expiration_date'] = ubo.attachment_expiration_date | ||
| ubo.holder_id.message_post( | ||
| body="The Identity Document Scan changed for this one: ", | ||
| attachment_ids=[env['ir.attachment'].create({ |
There was a problem hiding this comment.
Why are you creating a new attachment and reusing ubo.attachment_ids[-1]
| <record id="x_vat_declaration_recurrence_field_selection_quarterly" model="ir.model.fields.selection"> | ||
| <field name="name">Quarterly</field> | ||
| <field name="field_id" ref="x_vat_declaration_recurrence_field_res_partner" /> | ||
| <field name="value">Quarterly</field> |
There was a problem hiding this comment.
maybe stick to lowercases for values?
Suggested change
| <field name="value">Quarterly</field> | |
| <field name="value">quarterly</field> |
Comment on lines
+277
to
+278
| <field name="name">x_assistant_id</field> | ||
| <field name="field_description">Assistant</field> |
There was a problem hiding this comment.
Suggested change
| <field name="name">x_assistant_id</field> | |
| <field name="field_description">Assistant</field> | |
| <field name="name">x_assistant_ids</field> | |
| <field name="field_description">Assistants</field> |
Comment on lines
+285
to
+286
| <field name="name">x_reviewer_id</field> | ||
| <field name="field_description">Reviewer</field> |
There was a problem hiding this comment.
Suggested change
| <field name="name">x_reviewer_id</field> | |
| <field name="field_description">Reviewer</field> | |
| <field name="name">x_reviewer_ids</field> | |
| <field name="field_description">Reviewers</field> |
Comment on lines
+58
to
+62
| <xpath expr="//group[@id='accounting_firm_id_page_left_group']" position="inside"> | ||
| <xpath expr="//field[@name='ubo_national_identifier']" position="move"/> | ||
| <xpath expr="//field[@name='ubo_birth_date']" position="move"/> | ||
| <xpath expr="//field[@name='ubo_birth_place']" position="move"/> | ||
| </xpath> |
There was a problem hiding this comment.
Don't use xpath for no reason, just move the content up (line 29)
| <list editable="bottom"> | ||
| <field name="x_name"/> | ||
| <field name="x_level"/> | ||
| <field name="x_explanation" width="500"/> |
There was a problem hiding this comment.
Why 500? Have you tried opening the view in mobile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.