-
-
Notifications
You must be signed in to change notification settings - Fork 734
Fill in missing build flags for core/sys/windows
package
#5066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
add #+build windows
add #+build windows
Hmm, I see builds are failing on D3D Here's all the dist packages that the build depends upon:``` $ odin build src -build-mode:obj -target:js_wasm32 ... -export-dependencies:json -export-dependencies-file:dep.json $ cat dep.json | grep ".odin" | ... | sort | uniq base/runtime core/bufio core/bytes core/c core/compress core/compress/zlib core/encoding/ansi core/encoding/json core/fmt core/hash core/image core/image/png core/io core/log core/math/bits core/math/linalg core/math core/mem core/os core/reflect core/simd core/slice core/strconv/decimal core/strconv core/strings core/sync core/time/datetime core/time core/unicode core/unicode/utf16 core/unicode/utf8 vendor/box2d vendor/box2d/lib vendor/box2d vendor/sdl2 vendor/vulkan vendor/x11/xlib ``` And, diff'd from Linux executable build:``` $ diff LIN_DEP_PACKAGES WEB_DEP_PACKAGES -y base/runtime base/runtime core/bufio core/bufio core/bytes core/bytes core/c core/c core/c/libc < core/compress core/compress core/compress/zlib core/compress/zlib core/container/queue < core/dynlib < core/encoding/ansi core/encoding/ansi core/encoding/base64 < core/encoding/json core/encoding/json core/fmt core/fmt core/hash core/hash core/image core/image core/image/png core/image/png core/io core/io core/log core/log core/math/bits core/math/bits core/math/linalg core/math/linalg core/math core/math core/math/rand < core/mem core/mem core/os core/os core/os/os2 < core/os < core/path/filepath < core/prof/spall < core/reflect core/reflect core/simd core/simd core/slice core/slice core/strconv/decimal core/strconv/decimal core/strconv core/strconv core/strings core/strings core/sync core/sync core/sync/chan < core/sync < core/sys/linux < core/sys/posix < core/sys/unix < core/sys/valgrind < core/testing < core/thread < core/time/datetime core/time/datetime core/time core/time core/unicode core/unicode core/unicode/utf16 core/unicode/utf16 core/unicode/utf8 core/unicode/utf8 vendor/box2d vendor/box2d vendor/box2d/lib vendor/box2d/lib vendor/box2d vendor/box2d vendor/sdl2 vendor/sdl2 vendor/vulkan vendor/vulkan vendor/x11/xlib vendor/x11/xlib ``` (apparently code blocks don't work in Actually, I'm realizing that I can only export the web build dependencies if the build doesn't fail, so the exported list probably doesn't have the offender in it since I can only succeed building with this PR's patch... d'oh Here are the files that:
I think it's likely the One fix for this may be to split |
Okay, so I've sourced my real issue: I copied it into My wasm build went normally, without this PR's patch (so, the only changes to the source tree was However, that file is autogenerated, so hacking this seems unwise. Please advise. I'm also uncertain why I don't get these build errors when building the Linux executable, and only the wasm obj, even though |
These files are triggering compilation errors on my Linux machine, which are fixed with these build flags.
Thanks for reviewing.
EDIT: For context, the errors I'm trying to solve, specifically building obj for
js_wasm32
: