0.1.2 - adds options V2 page, allows whitelisting #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After using this extension for a number of years, I've run across a handful of sites that use .gifs as button, etc. This extension wrongfully targets them and often accidentally breaks the formatting and functionality of the website. My fix simply implements a whitelist of sites that disable the content scripts through programmatic injection. Within background.js, my edits check a parsed version of the contents of the whitelist versus the current domain. If there are matches, the extension never executes any changes on the page. - Contribution by Zach Hardesty: http://zachhardesty.com
This was referenced Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After using this extension for a number of years, I've run across a
handful of sites that use .gifs as button, etc. This extension wrongfully
targets them and often accidentally breaks the formatting and
functionality of the website.
My fix simply implements a whitelist of sites that disable the content
scripts through programmatic injection. Within background.js, my edits
check a parsed version of the contents of the whitelist versus the current
domain. If there are matches, the extension never executes any changes on
the page.