forked from akkeris/kafka-api
-
Notifications
You must be signed in to change notification settings - Fork 0
big change to new direction #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
murrayres
wants to merge
4
commits into
master
Choose a base branch
from
bigchange
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| .idea | ||
| out | ||
| target | ||
| kafkatools.iml | ||
| .classpath | ||
| .project | ||
| .settings/ | ||
| .vscode/ | ||
| exports.sh | ||
| env.env | ||
| prd.sh | ||
| qa.sh | ||
| stg.sh | ||
|
|
||
|
|
||
| testtopic | ||
| kafka_client_jaas.config | ||
| local.sh | ||
| oldway | ||
| eclipse-formatter.xml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| -- DDL generated by Postico 1.4.2 | ||
| -- Not all database features are supported. Do not use for backup. | ||
|
|
||
| -- Table Definition ---------------------------------------------- | ||
|
|
||
| CREATE TABLE IF NOT EXISTS provision_user ( | ||
| userid text DEFAULT uuid_generate_v4() PRIMARY KEY, | ||
| password text, | ||
| username text UNIQUE, | ||
| created_timestamp timestamp without time zone DEFAULT now(), | ||
| claimed boolean, | ||
| claimed_timestamp timestamp without time zone, | ||
| cluster text | ||
| ); | ||
|
|
||
| -- Indices ------------------------------------------------------- | ||
|
|
||
| CREATE UNIQUE INDEX IF NOT EXISTS username_uniqu ON provision_user(username text_ops); | ||
| CREATE UNIQUE INDEX IF NOT EXISTS provision_user_pkey ON provision_user(userid text_ops); | ||
|
|
||
|
|
||
| -- DDL generated by Postico 1.4.2 | ||
| -- Not all database features are supported. Do not use for backup. | ||
|
|
||
| -- Table Definition ---------------------------------------------- | ||
|
|
||
| CREATE TABLE IF NOT EXISTS provision_topic ( | ||
| topicid text DEFAULT uuid_generate_v4() PRIMARY KEY, | ||
| topic text UNIQUE, | ||
| partitions integer, | ||
| replicas integer, | ||
| retentionms integer, | ||
| cleanuppolicy text, | ||
| created_timestamp timestamp without time zone DEFAULT now(), | ||
| cluster text, | ||
| organization text, | ||
| updated_timestamp timestamp without time zone, | ||
| description text | ||
| ); | ||
|
|
||
| -- Indices ------------------------------------------------------- | ||
|
|
||
| CREATE UNIQUE INDEX IF NOT EXISTS topic_unique ON provision_topic(topic text_ops); | ||
| CREATE UNIQUE INDEX IF NOT EXISTS provision_topic_pkey ON provision_topic(topicid text_ops); | ||
|
|
||
|
|
||
| -- DDL generated by Postico 1.4.2 | ||
| -- Not all database features are supported. Do not use for backup. | ||
|
|
||
| -- Table Definition ---------------------------------------------- | ||
|
|
||
| CREATE TABLE IF NOT EXISTS provision_consumergroup ( | ||
| consumergroupid text DEFAULT uuid_generate_v4(), | ||
| userid text, | ||
| topicid text, | ||
| consumergroupname text, | ||
| active boolean, | ||
| created_timestamp timestamp without time zone DEFAULT now(), | ||
| updated_timestamp timestamp without time zone, | ||
| cluster text | ||
| ); | ||
|
|
||
|
|
||
|
|
||
| -- DDL generated by Postico 1.4.2 | ||
| -- Not all database features are supported. Do not use for backup. | ||
|
|
||
| -- Table Definition ---------------------------------------------- | ||
|
|
||
| CREATE TABLE IF NOT EXISTS provision_acl ( | ||
| aclid text DEFAULT uuid_generate_v4() PRIMARY KEY, | ||
| userid text, | ||
| topicid text, | ||
| role text, | ||
| created_timestamp timestamp without time zone DEFAULT now(), | ||
| cluster text, | ||
| CONSTRAINT acl_unique UNIQUE (userid, topicid, role) | ||
| ); | ||
|
|
||
| -- Indices ------------------------------------------------------- | ||
|
|
||
| CREATE UNIQUE INDEX IF NOT EXISTS provision_acl_pkey ON provision_acl(aclid text_ops); | ||
| CREATE UNIQUE INDEX IF NOT EXISTS acl_unique ON provision_acl(userid text_ops,topicid text_ops,role text_ops); | ||
|
|
||
|
|
||
| -- DDL generated by Postico 1.4.2 | ||
| -- Not all database features are supported. Do not use for backup. | ||
|
|
||
| -- Table Definition ---------------------------------------------- | ||
|
|
||
| CREATE OR REPLACE VIEW credentials AS SELECT provision_user.username, | ||
| provision_user.password, | ||
| provision_topic.topic, | ||
| provision_acl.role, | ||
| provision_consumergroup.consumergroupname, | ||
| provision_user.cluster | ||
| FROM provision_consumergroup, | ||
| provision_acl, | ||
| provision_user, | ||
| provision_topic | ||
| WHERE provision_consumergroup.topicid = provision_acl.topicid AND provision_acl.userid = provision_user.userid AND provision_acl.topicid = provision_topic.topicid AND provision_acl.role = 'consumer'::text AND provision_user.cluster = provision_topic.cluster AND provision_topic.cluster = provision_acl.cluster AND provision_acl.cluster = provision_consumergroup.cluster AND provision_consumergroup.active = true | ||
| UNION ALL | ||
| SELECT provision_user.username, | ||
| provision_user.password, | ||
| provision_topic.topic, | ||
| provision_acl.role, | ||
| ''::text AS consumergroupname, | ||
| provision_user.cluster | ||
| FROM provision_acl, | ||
| provision_user, | ||
| provision_topic | ||
| WHERE provision_acl.userid = provision_user.userid AND provision_acl.topicid = provision_topic.topicid AND provision_user.cluster = provision_topic.cluster AND provision_topic.cluster = provision_acl.cluster AND provision_acl.role = 'producer'::text; | ||
|
|
||
|
|
||
|
|
||
| -- DDL generated by Postico 1.4.2 | ||
| -- Not all database features are supported. Do not use for backup. | ||
|
|
||
| -- Table Definition ---------------------------------------------- | ||
|
|
||
| CREATE OR REPLACE VIEW consumergroups AS SELECT provision_user.username, | ||
| provision_topic.topic, | ||
| provision_consumergroup.consumergroupname, | ||
| provision_consumergroup.cluster | ||
| FROM provision_consumergroup, | ||
| provision_topic, | ||
| provision_user | ||
| WHERE provision_consumergroup.userid = provision_user.userid AND provision_consumergroup.topicid = provision_topic.topicid AND provision_consumergroup.active = true; | ||
|
|
||
|
|
||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Codacy found a critical ErrorProne issue: Use COPY instead of ADD for files and folders
The issue identified by Hadolint regarding the use of
ADDinstead ofCOPYis based on best practices in Dockerfile optimization. TheADDinstruction is more powerful thanCOPYbecause it can handle remote URLs and automatically extract tar files. However, when you are simply copying files or directories from the build context to the image, it is recommended to useCOPYinstead ofADD. This makes your intentions clearer and can lead to smaller images, asCOPYdoes not have the additional overhead of the extra features provided byADD.To fix the issue, you should replace the
ADDinstruction withCOPYfor thecreate.sqlfile. Here’s the single line change:This comment was generated by an experimental AI tool.