-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Enhancement: Adjust binary file location (#535) #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
can you resolve ci fail? @yadunand-kamath |
CMakeLists.txt
Outdated
@@ -6,7 +6,11 @@ project(minidb) | |||
MESSAGE(STATUS "This is Project source dir " ${PROJECT_SOURCE_DIR}) | |||
MESSAGE(STATUS "This is PROJECT_BINARY_DIR dir " ${PROJECT_BINARY_DIR}) | |||
|
|||
SET(EXECUTABLE_OUTPUT_PATH ${PROJECT_BINARY_DIR}/bin) | |||
# Main executables | |||
SET(EXECUTABLE_OUTPUT_PATH ${PROJECT_BINARY_DIR}/bin/exe) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
putting binary file in ${PROJECT_BINARY_DIR}/bin
and putting ut file in ${PROJECT_BINARY_DIR}/unittest
is better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I'll do that
Signed-off-by: Yadunand Kamath <[email protected]>
6f31a1e
to
66bfeb4
Compare
thanks for your contribution, and can you resolve the ci fail? maybe you need to change some file paths in github workflow. @yadunand-kamath |
Signed-off-by: Yadunand Kamath <[email protected]>
@yadunand-kamath please take a look again, thank you! |
Previously, all unittest files and binary executable files (such as observer/obclient) were put together in
build_*/bin
directory.After the enhancement, the binary executable files and the unittest files have been separated into the following directories respectively:
build_*/bin
build_*/unittest
Issue Number: close #535
After enhancement