Skip to content

Enhancement: Adjust binary file location (#535) #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yadunand-kamath
Copy link

@yadunand-kamath yadunand-kamath commented Apr 5, 2025

Previously, all unittest files and binary executable files (such as observer/obclient) were put together in build_*/bin directory.
After the enhancement, the binary executable files and the unittest files have been separated into the following directories respectively:

  • build_*/bin
  • build_*/unittest

Issue Number: close #535

After enhancement

> cd build_debug
> ls bin/
clog_dump  cpplings  obclient  oblsm_bench  oblsm_cli  observer
> ls unittesttest/
CMakeFiles                 bplus_tree_log_entry_test  codec_test                integer_generator_test  mem_pool_test        ob_lsm_test       pax_storage_test     thread_pool_executor_test
CTestTestfile.cmake        bplus_tree_log_test        common                    log_buffer_test         mvcc_trx_log_test    ob_skiplist_test  persist_test
Makefile                   bplus_tree_test            composite_tuple_test      log_entry_test          ob_arena_test        ob_table_test     pidfile_test
aggregate_hash_table_test  buffer_pool_log_test       disk_buffer_pool_test     log_file_test           ob_block_test        ob_util_test      record_manager_test
arithmetic_operator_test   catalog_test               disk_log_handler_test     log_test                ob_bloomfilter_test  oblsm             ring_buffer_test
bitmap_test                chunk_test                 double_write_buffer_test  lower_bound_test        ob_compaction_test   observer          serializer_test
bp_manager_test            cmake_install.cmake        expression_test           md5_test                ob_lru_cache_test    parser_test       simple_queue_test

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2025

CLA assistant check
All committers have signed the CLA.

@nautaa nautaa self-requested a review April 6, 2025 11:20
@nautaa
Copy link
Member

nautaa commented Apr 6, 2025

can you resolve ci fail? @yadunand-kamath

CMakeLists.txt Outdated
@@ -6,7 +6,11 @@ project(minidb)
MESSAGE(STATUS "This is Project source dir " ${PROJECT_SOURCE_DIR})
MESSAGE(STATUS "This is PROJECT_BINARY_DIR dir " ${PROJECT_BINARY_DIR})

SET(EXECUTABLE_OUTPUT_PATH ${PROJECT_BINARY_DIR}/bin)
# Main executables
SET(EXECUTABLE_OUTPUT_PATH ${PROJECT_BINARY_DIR}/bin/exe)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting binary file in ${PROJECT_BINARY_DIR}/bin and putting ut file in ${PROJECT_BINARY_DIR}/unittest is better?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I'll do that

@nautaa
Copy link
Member

nautaa commented Apr 22, 2025

thanks for your contribution, and can you resolve the ci fail? maybe you need to change some file paths in github workflow. @yadunand-kamath

@nautaa
Copy link
Member

nautaa commented Apr 23, 2025

@yadunand-kamath please take a look again, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adjust binary file location
3 participants