Skip to content

Conversation

@Octachron
Copy link
Member

Alternative ocaml dependency analyzer

CHANGES:
  • Support 5.4

features:

  • track external declarations

]
]
dev-repo: "git+https://github.com/Octachron/codept.git"
x-maintenance-intent: "latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x-maintenance-intent: "latest"
x-maintenance-intent: "(latest)"

minor syntactic nit to follow https://github.com/ocaml/opam-repository/blob/master/governance/policies/archiving.md

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks for the nit !

]
]
dev-repo: "git+https://github.com/Octachron/codept.git"
x-maintenance-intent: "latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x-maintenance-intent: "latest"
x-maintenance-intent: "(latest)"

same

Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the runtest target for codept-lib.0.12.2 is failing across the board, for example on 5.4:

[ERROR] The compilation of codept-lib.0.12.2 failed at "dune build -p codept-lib -j 71 @install @runtest".

#=== ERROR while compiling codept-lib.0.12.2 ==================================#
# context              2.5.0~alpha1 | linux/x86_64 | ocaml-base-compiler.5.4.0 | pinned(https://github.com/Octachron/codept/releases/download/0.12.2/codept-0.12.2.tbz)
# path                 ~/.opam/5.4/.opam-switch/build/codept-lib.0.12.2
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p codept-lib -j 71 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/codept-lib-7-7d8268.env
# output-file          ~/.opam/log/codept-lib-7-7d8268.out
### output ###
# Error: No rule found for full/codept.exe
# -> required by alias tests/runtest in tests/dune:36
# (cd _build/default/tests && ./run.exe ../../..)
# Success.

CHANGES:

  * Support 5.4

  * track external declarations
@Octachron Octachron force-pushed the release-codept-0.12.2 branch from f4a1814 to b058f20 Compare October 27, 2025 23:07
@Octachron
Copy link
Member Author

I have disabled the test from the library for this release because the testsuite is currently shared between the executable and the library. The two parts would be made more independent next version, but I believe that running the shared testsuite for only the executable should be enough temporarily.

(The macOS failure looks like they are caused the testsuite not closing enough file descriptors, this will be fixed next version too)

]
]
dev-repo: "git+https://github.com/Octachron/codept.git"
x-maintenance-intent: "(latest)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x-maintenance-intent: "(latest)"
x-maintenance-intent: "(latest)"
x-ci-accept-failures: ["macos-homebrew"]

a suggestion to silence the remaining macOS failures

@raphael-proust
Copy link
Contributor

CI failures are due to macos jail (EPIPE) only. It's good to merge but could use @jmid 's suggestion above.

Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@avsm avsm merged commit 3003310 into ocaml:master Oct 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants