-
Couldn't load subscription status.
- Fork 1.2k
[new release] codept (2 packages) (0.12.2) #28780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ] | ||
| ] | ||
| dev-repo: "git+https://github.com/Octachron/codept.git" | ||
| x-maintenance-intent: "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| x-maintenance-intent: "latest" | |
| x-maintenance-intent: "(latest)" |
minor syntactic nit to follow https://github.com/ocaml/opam-repository/blob/master/governance/policies/archiving.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks for the nit !
packages/codept/codept.0.12.2/opam
Outdated
| ] | ||
| ] | ||
| dev-repo: "git+https://github.com/Octachron/codept.git" | ||
| x-maintenance-intent: "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| x-maintenance-intent: "latest" | |
| x-maintenance-intent: "(latest)" |
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the runtest target for codept-lib.0.12.2 is failing across the board, for example on 5.4:
- codept-lib.0.12.2
- tests (failed: No rule found for full/codept.exe)
https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/f4a18146780a92bd0f959004974e908385e3997c/variant/compilers,5.4,codept-lib.0.12.2,tests
- tests (failed: No rule found for full/codept.exe)
[ERROR] The compilation of codept-lib.0.12.2 failed at "dune build -p codept-lib -j 71 @install @runtest".
#=== ERROR while compiling codept-lib.0.12.2 ==================================#
# context 2.5.0~alpha1 | linux/x86_64 | ocaml-base-compiler.5.4.0 | pinned(https://github.com/Octachron/codept/releases/download/0.12.2/codept-0.12.2.tbz)
# path ~/.opam/5.4/.opam-switch/build/codept-lib.0.12.2
# command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p codept-lib -j 71 @install @runtest
# exit-code 1
# env-file ~/.opam/log/codept-lib-7-7d8268.env
# output-file ~/.opam/log/codept-lib-7-7d8268.out
### output ###
# Error: No rule found for full/codept.exe
# -> required by alias tests/runtest in tests/dune:36
# (cd _build/default/tests && ./run.exe ../../..)
# Success.
CHANGES: * Support 5.4 * track external declarations
f4a1814 to
b058f20
Compare
|
I have disabled the test from the library for this release because the testsuite is currently shared between the executable and the library. The two parts would be made more independent next version, but I believe that running the shared testsuite for only the executable should be enough temporarily. (The macOS failure looks like they are caused the testsuite not closing enough file descriptors, this will be fixed next version too) |
| ] | ||
| ] | ||
| dev-repo: "git+https://github.com/Octachron/codept.git" | ||
| x-maintenance-intent: "(latest)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| x-maintenance-intent: "(latest)" | |
| x-maintenance-intent: "(latest)" | |
| x-ci-accept-failures: ["macos-homebrew"] |
a suggestion to silence the remaining macOS failures
|
CI failures are due to macos jail (EPIPE) only. It's good to merge but could use @jmid 's suggestion above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Alternative ocaml dependency analyzer
CHANGES:
features: