- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.2k
2 packages from rocq-prover/vsrocq at 2.3.2 #28761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 packages from rocq-prover/vsrocq at 2.3.2 #28761
Conversation
| Ci failures seem unrelated | 
| "sel" {>= "0.6.0"} | ||
| ] | ||
| conflicts: [ | ||
| "vscoq-language-server" {< "2.7~"} | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. I can easily imagine a new version conflicting with older ones, necessitating the conflicts entry.
In the current setup however
vscoq-language-server.2.3.2/opam has
depends: [ "vsrocq-language-server" {= version} ]
yet that dependency is simultaneously conflicting IIUC.
I believe this is why all vscoq-language-server.2.3.2 installations on the CI are failing with
(failed: [SKIP] Package not available).
We should probably refine the constraints, but you folks know the conflicts better than us...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gares What is your take on this?
vscoq-language-server.2.3.2 is uninstallable with the current constraints and conflicts.
It doesn't make much sense to merge an uninstallable package, does it? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, check the last comment
| Would you consider adding  | 
| "vsrocq-language-server" {= version} | ||
| ] | ||
| synopsis: "Compatibility meta package for the VsRocq language server after the Rocq renaming" | ||
| available: arch != "arm32" & arch != "x86_32" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| available: arch != "arm32" & arch != "x86_32" | |
| available: arch != "arm32" & arch != "x86_32" | |
| x-maintenance-intent: ["(latest)"] | 
| "vscoq-language-server" {< "2.7~"} | ||
| ] | ||
| synopsis: "VSRocq language server" | ||
| available: arch != "arm32" & arch != "x86_32" | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| available: arch != "arm32" & arch != "x86_32" | |
| available: arch != "arm32" & arch != "x86_32" | |
| x-maintenance-intent: ["(latest)"] | 
| I merged this upstream: https://github.com/rocq-prover/vsrocq/pull/1166/files | 
| "sel" {>= "0.6.0"} | ||
| ] | ||
| conflicts: [ | ||
| "vscoq-language-server" {< "2.7~"} | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "vscoq-language-server" {< "2.7~"} | |
| "vscoq-language-server" {< "2.2.7~"} | 
| Closing in favor of #28783 | 
This pull-request concerns:
vscoq-language-server.2.3.2: Compatibility meta package for the VsRocq language server after the Rocq renamingvsrocq-language-server.2.3.2: VSRocq language server🐫 Pull-request generated by opam-publish v2.5.0