Skip to content

Conversation

@vscoqbot
Copy link
Contributor

This pull-request concerns:

  • vscoq-language-server.2.3.2: Compatibility meta package for the VsRocq language server after the Rocq renaming
  • vsrocq-language-server.2.3.2: VSRocq language server


🐫 Pull-request generated by opam-publish v2.5.0

@gares
Copy link
Contributor

gares commented Oct 24, 2025

Ci failures seem unrelated

"sel" {>= "0.6.0"}
]
conflicts: [
"vscoq-language-server" {< "2.7~"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. I can easily imagine a new version conflicting with older ones, necessitating the conflicts entry.
In the current setup however
vscoq-language-server.2.3.2/opam has
depends: [ "vsrocq-language-server" {= version} ]
yet that dependency is simultaneously conflicting IIUC.

I believe this is why all vscoq-language-server.2.3.2 installations on the CI are failing with
(failed: [SKIP] Package not available).

We should probably refine the constraints, but you folks know the conflicts better than us...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gares What is your take on this?
vscoq-language-server.2.3.2 is uninstallable with the current constraints and conflicts.
It doesn't make much sense to merge an uninstallable package, does it? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, check the last comment

@jmid
Copy link
Member

jmid commented Oct 24, 2025

Would you consider adding x-maintenance-intent entries for these packages?
https://github.com/ocaml/opam-repository/blob/master/governance/policies/archiving.md

"vsrocq-language-server" {= version}
]
synopsis: "Compatibility meta package for the VsRocq language server after the Rocq renaming"
available: arch != "arm32" & arch != "x86_32"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
available: arch != "arm32" & arch != "x86_32"
available: arch != "arm32" & arch != "x86_32"
x-maintenance-intent: ["(latest)"]

"vscoq-language-server" {< "2.7~"}
]
synopsis: "VSRocq language server"
available: arch != "arm32" & arch != "x86_32"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
available: arch != "arm32" & arch != "x86_32"
available: arch != "arm32" & arch != "x86_32"
x-maintenance-intent: ["(latest)"]

@gares
Copy link
Contributor

gares commented Oct 25, 2025

I merged this upstream: https://github.com/rocq-prover/vsrocq/pull/1166/files
but I don't have the bot credentials at hand, please apply the fixes in comments.

"sel" {>= "0.6.0"}
]
conflicts: [
"vscoq-language-server" {< "2.7~"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"vscoq-language-server" {< "2.7~"}
"vscoq-language-server" {< "2.2.7~"}

@jmid
Copy link
Member

jmid commented Oct 28, 2025

Closing in favor of #28783

@jmid jmid closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants