Skip to content

Conversation

gares
Copy link
Contributor

@gares gares commented Sep 1, 2025

ELPI - Embeddable λProlog Interpreter

CHANGES:

Requires Menhir 20211230 and OCaml 4.13 or above.

  • Tooling:
    • port to ppxlib 0.36.0

CHANGES:

Requires Menhir 20211230 and OCaml 4.13 or above.

- Tooling:
  - port to ppxlib 0.36.0
Copy link
Contributor

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

I've made a couple of suggestions.
The package is also failing tests on the upcoming 5.4.0.
We could consider disabling tests there too.

gares and others added 2 commits September 2, 2025 09:49
@gares
Copy link
Contributor Author

gares commented Sep 2, 2025

thanks

@gares
Copy link
Contributor Author

gares commented Sep 2, 2025

The failure seems to be that ydump changed behavior w.r.t. indentation (or Format, if it uses format for breaking lines)

@gares
Copy link
Contributor Author

gares commented Sep 2, 2025

I guess the right fix on my side would be to use jsondiff rather than ydump+diff, but that has to go to another release...

@gares gares closed this Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants