-
Notifications
You must be signed in to change notification settings - Fork 1.2k
2 packages from ocsigen/lwt at 6.0.0~alpha01 #28222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
2 packages from ocsigen/lwt at 6.0.0~alpha01 #28222
Conversation
It seems to break lwt_log, which has been deprecated for a while anyway so maybe that's ok, I'll add a constraint |
I might have also broken some js uses, need to check if i broke all of them or just some e.g.,
|
A few packages broken by the removal of |
Could you send a PR with the necessary upper bounds? |
"base-unix" | ||
"curl" {= version} | ||
"lwt" | ||
"lwt" {<= "5.999"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"lwt" {<= "5.999"} | |
"lwt" {<= "6~"} |
This would prevent it and not force a 5
bound
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think it's all done. The CI still fails though. I think that lwt gets pinned which maybe bypasses the version check??
With this fix it should be fine. My only remaining worry is this obscure failure:
|
Next time please send the upper bounds separately, it keeps it lighter for the CI and it is easier to review |
the dune one seem to have passed now i'm opening a new PR with only the incompatibilities, I have found new ones :( |
#28482 compatibility PR |
c964ffe
to
ed83237
Compare
This pull-request concerns:
lwt.6.0.0~alpha01
: Promises and event-driven I/Olwt_direct.6.0.0~alpha01
: Direct-style control-flow andawait
for Lwt🐫 Pull-request generated by opam-publish v2.5.1