Skip to content

Conversation

@dvic
Copy link
Contributor

@dvic dvic commented Oct 14, 2025

Summary

  • Replace all occurrences of legacy ~/.claude/skills path with the correct ~/.config/superpowers/skills/skills path
  • Update shell script default paths in gardening and conversation tools
  • Update documentation examples and instructions across all affected skills
  • Update hook scripts and installation paths
  • Update test expectations to match new paths

Verification

All occurrences of ~/.claude/skills have been replaced except for git log references (which should remain unchanged). The new paths point to the actual location where skills are installed on the system.

Files Changed

  • Shell scripts: analyze-search-gaps.sh, garden.sh, check-*.sh
  • Documentation: SKILL.md, DEPLOYMENT.md, INDEXING.md, CLAUDE_MD_TESTING.md
  • Hooks: sessionEnd, install-hook, test-install-hook.sh
  • Tests: search-agent-template.test.ts
  • Prompts: search-agent.md

Summary by CodeRabbit

  • Documentation
    • Updated all instructions and examples to use the new base path: ~/.config/superpowers/skills/skills instead of ~/.claude/skills.
  • Refactor
    • Migrated default paths used by scripts and runtime hooks to the new configuration directory.
  • Tests
    • Updated test expectations to reflect the new command/path locations.
  • Chores
    • Aligned health checks, troubleshooting, and auxiliary scripts with the new path structure.

@coderabbitai
Copy link

coderabbitai bot commented Oct 14, 2025

Walkthrough

Updated filesystem paths from ~/.claude/... to ~/.config/superpowers/skills/skills/... across docs, scripts, hooks, and tests. One session hook and installer/test scripts now reference the relocated indexer path. No control-flow or runtime logic changes beyond path substitutions.

Changes

Cohort / File(s) Summary
Remembering Conversations Docs
skills/collaboration/remembering-conversations/DEPLOYMENT.md, skills/collaboration/remembering-conversations/INDEXING.md, skills/collaboration/remembering-conversations/tool/prompts/search-agent.md
Updated command examples and documented paths from ~/.claude/... to ~/.config/superpowers/skills/skills/....
Hooks & Installer
skills/collaboration/remembering-conversations/tool/hooks/sessionEnd, skills/collaboration/remembering-conversations/tool/install-hook, skills/collaboration/remembering-conversations/tool/test-install-hook.sh
Switched INDEXER path to $HOME/.config/superpowers/skills/skills/.../index-conversations; execution logic and conditions unchanged.
Tests
skills/collaboration/remembering-conversations/tool/src/search-agent-template.test.ts
Updated expected hard-coded search command path to the new ~/.config/superpowers/skills/skills/.../search-conversations.
Meta Gardening Scripts & Docs
skills/meta/gardening-skills-wiki/SKILL.md, skills/meta/gardening-skills-wiki/analyze-search-gaps.sh, skills/meta/gardening-skills-wiki/check-index-coverage.sh, skills/meta/gardening-skills-wiki/check-links.sh, skills/meta/gardening-skills-wiki/check-naming.sh, skills/meta/gardening-skills-wiki/garden.sh
Changed default SKILLS_DIR / path references to ~/.config/superpowers/skills/skills; behavior unchanged.
Testing Docs
skills/meta/testing-skills-with-subagents/examples/CLAUDE_MD_TESTING.md
Updated documentation path references to the new base directory.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant User
  participant App
  participant Hook as sessionEnd Hook
  participant Indexer as index-conversations

  User->>App: End session
  App->>Hook: Trigger sessionEnd
  Note right of Hook #DDEBF7: Check SESSION_ID and INDEXER executable path
  Hook-->>Indexer: Invoke (async) --session "$SESSION_ID"
  Indexer-->>Hook: Background indexing started
  Hook-->>App: Return immediately
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

A rabbit hopped through symlinks and rails,
Nudged paths from burrows to bright new trails.
Hooks still twitch, indexers still hum—
Same work, new meadow, the changes are done.
Thump-thump! configs neat, my whiskers approve 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and accurately summarizes the primary change of updating all skill path references from the old ~/.claude/skills directory to the new ~/.config/superpowers/skills/skills location, making it easy for a reviewer to understand the core modification at a glance. It is concise, specific, and directly relates to the main focus of the pull request without extraneous details. The phrasing avoids vague terms and correctly highlights the most significant update.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0415c63 and 8683c31.

📒 Files selected for processing (14)
  • skills/collaboration/remembering-conversations/DEPLOYMENT.md (3 hunks)
  • skills/collaboration/remembering-conversations/INDEXING.md (2 hunks)
  • skills/collaboration/remembering-conversations/tool/hooks/sessionEnd (1 hunks)
  • skills/collaboration/remembering-conversations/tool/install-hook (1 hunks)
  • skills/collaboration/remembering-conversations/tool/prompts/search-agent.md (1 hunks)
  • skills/collaboration/remembering-conversations/tool/src/search-agent-template.test.ts (1 hunks)
  • skills/collaboration/remembering-conversations/tool/test-install-hook.sh (1 hunks)
  • skills/meta/gardening-skills-wiki/SKILL.md (9 hunks)
  • skills/meta/gardening-skills-wiki/analyze-search-gaps.sh (1 hunks)
  • skills/meta/gardening-skills-wiki/check-index-coverage.sh (1 hunks)
  • skills/meta/gardening-skills-wiki/check-links.sh (1 hunks)
  • skills/meta/gardening-skills-wiki/check-naming.sh (1 hunks)
  • skills/meta/gardening-skills-wiki/garden.sh (1 hunks)
  • skills/meta/testing-skills-with-subagents/examples/CLAUDE_MD_TESTING.md (7 hunks)
🚧 Files skipped from review as they are similar to previous changes (8)
  • skills/meta/gardening-skills-wiki/garden.sh
  • skills/collaboration/remembering-conversations/tool/install-hook
  • skills/collaboration/remembering-conversations/tool/hooks/sessionEnd
  • skills/meta/testing-skills-with-subagents/examples/CLAUDE_MD_TESTING.md
  • skills/collaboration/remembering-conversations/tool/src/search-agent-template.test.ts
  • skills/collaboration/remembering-conversations/tool/prompts/search-agent.md
  • skills/meta/gardening-skills-wiki/analyze-search-gaps.sh
  • skills/meta/gardening-skills-wiki/check-index-coverage.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dvic
Copy link
Contributor Author

dvic commented Oct 14, 2025

Or should this all use SUPERPOWERS_SKILLS_ROOT?

@obra
Copy link
Owner

obra commented Oct 14, 2025

TY! Give me a couple of days. I think I have a neat way of solving this.

@dvic
Copy link
Contributor Author

dvic commented Oct 14, 2025

TY! Give me a couple of days. I think I have a neat way of solving this.

awesome! looking forward 👍🏼

…ills/skills

Replace all occurrences of the legacy ~/.claude/skills path with the correct
~/.config/superpowers/skills/skills path throughout the codebase.

Changes:
- Update shell script default paths
- Update documentation examples and instructions
- Update hook scripts and installation paths
- Update test expectations
- Update subagent prompt templates

This ensures consistency with the actual skills location on the system.
@dvic dvic force-pushed the fix/config-paths-from-src branch from 0415c63 to 8683c31 Compare October 15, 2025 19:20
@031282
Copy link

031282 commented Oct 16, 2025

Summary

  • Replace all occurrences of legacy ~/.claude/skills path with the correct ~/.config/superpowers/skills/skills path
  • Update shell script default paths in gardening and conversation tools
  • Update documentation examples and instructions across all affected skills
  • Update hook scripts and installation paths
  • Update test expectations to match new paths

Verification

All occurrences of ~/.claude/skills have been replaced except for git log references (which should remain unchanged). The new paths point to the actual location where skills are installed on the system.

Files Changed

  • Shell scripts: analyze-search-gaps.sh, garden.sh, check-*.sh
  • Documentation: SKILL.md, DEPLOYMENT.md, INDEXING.md, CLAUDE_MD_TESTING.md
  • Hooks: sessionEnd, install-hook, test-install-hook.sh
  • Tests: search-agent-template.test.ts
  • Prompts: search-agent.md

Summary by CodeRabbit

  • Documentation
    • Updated all instructions and examples to use the new base path: ~/.config/superpowers/skills/skills instead of ~/.claude/skills.
  • Refactor
    • Migrated default paths used by scripts and runtime hooks to the new configuration directory.
  • Tests
    • Updated test expectations to reflect the new command/path locations.
  • Chores
    • Aligned health checks, troubleshooting, and auxiliary scripts with the new path structure.

@nickolasclarke
Copy link

oh I should have probably commented here instead of opening #22. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants