Skip to content

Conversation

@shwetapsdet
Copy link
Collaborator

No description provided.

@shwetapsdet shwetapsdet changed the title Updated the github workflow to add OpenAI Key and updated the eval logic Added multiple MCP server as well as enhanced code structure for Feature file Nov 17, 2025
Copy link
Contributor

@drpebcak drpebcak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks ok to me. we should document the values of a lot of these secrets though - its not easy to maintain this right now because i dont know what some of these values are. typically we would put those in 1password. @tybalex can you work with @shwetapsdet to find a solution that ensures we have these recorded somewhere for posterity?

@tybalex
Copy link
Contributor

tybalex commented Nov 17, 2025

mostly looks ok to me. we should document the values of a lot of these secrets though - its not easy to maintain this right now because i dont know what some of these values are. typically we would put those in 1password. @tybalex can you work with @shwetapsdet to find a solution that ensures we have these recorded somewhere for posterity?

yeah I will add the values to 1password.

@drpebcak
Copy link
Contributor

@shwetapsdet can you resolve the conflicts here, and then update this PR to incorporate the changes in #8? Once those are in we can change the automation slightly to launch the mcp servers we are adding to the catalog to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants