remove ViewPropTypes #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we merge this ? I also have the warning.... seems like the package hasn't been maintained for a while... |
|
+1 |
anoukhello
added a commit
to pass-culture/pass-culture-app-native
that referenced
this pull request
May 24, 2022
…nore for test warning Add a log ignore for this warning: "ViewPropTypes will be removed from React Native. Migrate to ViewPropTypes exported from'deprecated-react-native-prop-types'" This warning comes from modules react-native-dash and react-native-date-picker that still use ViewPropTypes. We'll be able to remove this log ignore once react-native-dash have remove references to ViewPropTypes (obipawan/react-native-dash#36) and once we bump react-native-date-picker to 4.2.2 version
anoukhello
added a commit
to pass-culture/pass-culture-app-native
that referenced
this pull request
May 27, 2022
…nore for test warning Add a log ignore for this warning: "ViewPropTypes will be removed from React Native. Migrate to ViewPropTypes exported from'deprecated-react-native-prop-types'" This warning comes from modules react-native-dash and react-native-date-picker that still use ViewPropTypes. We'll be able to remove this log ignore once react-native-dash have remove references to ViewPropTypes (obipawan/react-native-dash#36) and once we bump react-native-date-picker to 4.2.2 version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed references to
ViewPropTypes, a deprecated type from thereact-nativepackage. The new setup should allow for web support, asreact-native-webhasn't supportedViewPropTypessince its version 0.12 (now on 0.17.5).Should fix #37