Skip to content

Added ability to configure OAuthToken at runtime #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added ability to configure OAuthToken at runtime #125

wants to merge 2 commits into from

Conversation

pashamesh
Copy link

No description provided.

ruipenso
ruipenso requested changes Nov 23, 2017
View reviewed changes
Copy link
Member

@ruipenso ruipenso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the motivation for this?

@pashamesh
Copy link
Author

This will allows to change cookie expiration after application is configured. For example to handle remember me functionality.
Please check test (https://github.com/oauthjs/angular-oauth2/pull/125/files#diff-c7dae382019f82458da39f461f216b47R56).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruipenso ruipenso ruipenso requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pashamesh @ruipenso