Jules PR #468
Jules PR #468
Conversation
…. I also verified the changes by reading the file.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
|
Visit the preview URL for this PR (updated for commit ab5c0ee): https://nyx-rustdoc--pr468-fix-documentation-ty-e5iqodyh.web.app (expires Wed, 12 Nov 2025 19:19:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d8e2a55934352d850c15d11866c39eb2d2e029be |
|
|
||
| let velocity = osc.velocity_km_s; | ||
| // Note the 1e3 factor to convert drag units from ((kg * km^2 * s^-2) / m^1) to (kg * km * s^-2) | ||
| // A factor of 1e3 is needed to convert the acceleration to km/s^2. |
There was a problem hiding this comment.
Undo this change, the previous comment made the units explicit and it's very helpful here.
| AtmDensity::Constant(rho) => { | ||
| let velocity = osc_drag_frame.velocity_km_s; | ||
| // Note the 1e3 factor to convert drag units from ((kg * km^2 * s^-2) / m^1) to (kg * km * s^-2) | ||
| // A factor of 1e3 is needed to convert the acceleration to km/s^2. |
|
|
||
| let velocity = velocity_integr_frame - osc_drag_frame.velocity_km_s; | ||
| // Note the 1e3 factor to convert drag units from ((kg * km^2 * s^-2) / m^1) to (kg * km * s^-2) | ||
| // A factor of 1e3 is needed to convert the acceleration to km/s^2. |
|
|
||
| let velocity = velocity_integr_frame - osc_drag_frame.velocity_km_s; | ||
| // Note the 1e3 factor to convert drag units from ((kg * km^2 * s^-2) / m^1) to (kg * km * s^-2) | ||
| // A factor of 1e3 is needed to convert the acceleration to km/s^2. |
|
|
||
| /// Define the spherical harmonic models. | ||
| /// This module allows loading gravity models from [PDS](http://pds-geosciences.wustl.edu/), [EGM2008](http://earth-info.nga.mil/GandG/wgs84/gravitymod/egm2008/) and GMAT's own COF files. | ||
| /// Spherical harmonic gravity models. |
| /// > For more best practices of these integrators (which clone those in GMAT), please refer to the | ||
| /// > [GMAT reference](https://github.com/ChristopherRabotin/GMAT/blob/37201a6290e7f7b941bc98ee973a527a5857104b/doc/help/src/Resource_NumericalIntegrators.xml#L1292). | ||
| /// > (Source)[https://github.com/ChristopherRabotin/GMAT/blob/37201a6290e7f7b941bc98ee973a527a5857104b/src/base/forcemodel/ODEModel.cpp#L3004] | ||
| /// An RSS state error control. Recommended for high-accuracy simulations. |
There was a problem hiding this comment.
Keep the previous documentation of this enum variant.
| /*! # nyx-space | ||
| [Nyx](https://en.wikipedia.org/wiki/Nyx): Blazing fast high-fidelity astrodynamics for Monte Carlo analyzes of constellations, interplanetary missions, and deep space flight navigation. | ||
| [Nyx](https://en.wikipedia.org/wiki/Nyx): High-fidelity, fast astrodynamics toolkit for spacecraft navigation, mission design, and Monte Carlo analyses. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
=======================================
Coverage 68.44% 68.44%
=======================================
Files 96 96
Lines 14727 14727
=======================================
Hits 10080 10080
Misses 4647 4647 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jules PR
PR created automatically by Jules for task 6418142019831393315