fix(build/tree-sitter): race condition when building many parsers simultaneously #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
suggestion: we have a test case that builds a tree-sitter parser. I suppose we could change it to spawn multiple builds in parallel. |
vhyrro
force-pushed
the
push-kxyrtrotuqvn
branch
from
13ee0e2 to
2bf1e00
Compare
vhyrro
force-pushed
the
push-kxyrtrotuqvn
branch
from
2bf1e00 to
e88ec2f
Compare
done |
mrcjkb
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't test directly through the devshell since I'm in a region with poor internet currently, but a quick run of
parallelwith 4 separate treesitter installations has stopped throwing an error, so I assume this has fixed the problem. Further testing will be necessary.