Skip to content

Raise error if no files are found #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 8, 2025
Merged

Raise error if no files are found #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a5dc1e
Raise error if no files are found
seanbudd Oct 8, 2025
146c409
fix rel path
seanbudd Oct 8, 2025
edce479
fix rel path
seanbudd Oct 8, 2025
c292b9f
fix rel path
seanbudd Oct 8, 2025
347b4c8
fix paths
seanbudd Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/testCode.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ jobs:
shell: cmd
# E2E: test to check the script can be run, no need to actually test the file.
# The internal checks are covered with unit tests.
run: .\runvalidate.bat --dry-run _test/testData/addons/fake/13.0.json tests\testData\nvdaAPIVersions.json
run: .\runvalidate.bat --dry-run tests/testData/addons/fake/13.0.0.json tests/testData/nvdaAPIVersions.json
- name: Get sha256
shell: cmd
# E2E: test to check the script can be run
run: .\runsha.bat tests\testData\fake.nvda-addon
run: .\runsha.bat tests/testData/fake.nvda-addon
- name: Generate json file
shell: cmd
# E2E: test to check the script can be run
run: .\runcreatejson.bat -f tests\testData\fake.nvda-addon --dir tests\testOutput\test_runcreatejson --channel=stable --publisher=fakepublisher --sourceUrl=https://github.com/fake/ --url=https://github.com/fake.nvda-addon --licName="GPL v2" --licUrl="https://www.gnu.org/licenses/gpl-2.0.html"
run: .\runcreatejson.bat -f tests/testData/fake.nvda-addon --dir tests/testOutput/test_runcreatejson --channel=stable --publisher=fakepublisher --sourceUrl=https://github.com/fake/ --url=https://github.com/fake.nvda-addon --licName="GPL v2" --licUrl="https://www.gnu.org/licenses/gpl-2.0.html"
3 changes: 3 additions & 0 deletions _validate/validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,9 @@ def main():
if errorOutputFile and os.path.exists(errorOutputFile):
os.remove(errorOutputFile)

if not addonFiles:
raise ValueError(f"No files found matching: {args.filePathGlob}")

if not args.dry_run:
anyErrors = False
for filename in addonFiles:
Expand Down
Loading