Skip to content

Issue#304: Fix unable to detect a pattern from default theme having same id as the pattern in the base theme. #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from
Open

Issue#304: Fix unable to detect a pattern from default theme having same id as the pattern in the base theme. #305

wants to merge 1 commit into from

Conversation

msnassar
Copy link

@msnassar msnassar commented Sep 3, 2020

Fix Issue #304

@vever001
Copy link

This works nicely but as discussed yesterday, we should provide test in the ui_patterns PR.
So Antonio will more likely merge the PR.

@WidgetsBurritos WidgetsBurritos mentioned this pull request Sep 25, 2020
Open
@WidgetsBurritos
Copy link

There is another issue with the getDirectories() method that I outlined here: #308

I think @vever001's proposal in #304 (comment) might be a better strategy here.

@kp77 kp77 mentioned this pull request Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msnassar @vever001 @WidgetsBurritos