-
Notifications
You must be signed in to change notification settings - Fork 104
sql-formatter: fix multi file input #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no worries. can you also file an upstream issue, so we can eventually remove the fix? |
You mean to sql-formatter itself?
Jonas Chevalier ***@***.***> schrieb am Fr., 28. März 2025,
16:17:
… no worries. can you also file an upstream issue, so we can eventually
remove the fix?
—
Reply to this email directly, view it on GitHub
<#328 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABJDTJE3XKTDLRKYMCUAZ32WVKVRAVCNFSM6AAAAABZ67U6SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRRGY3DMMZYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: zimbatm]*zimbatm* left a comment (numtide/treefmt-nix#328)
<#328 (comment)>
no worries. can you also file an upstream issue, so we can eventually
remove the fix?
—
Reply to this email directly, view it on GitHub
<#328 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABJDTJE3XKTDLRKYMCUAZ32WVKVRAVCNFSM6AAAAABZ67U6SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRRGY3DMMZYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
sql-formatter-org/sql-formatter#552
Marvin Preuss ***@***.***> schrieb am Fr., 28. März 2025, 19:14:
… You mean to sql-formatter itself?
Jonas Chevalier ***@***.***> schrieb am Fr., 28. März 2025,
16:17:
> no worries. can you also file an upstream issue, so we can eventually
> remove the fix?
>
> —
> Reply to this email directly, view it on GitHub
> <#328 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABJDTJE3XKTDLRKYMCUAZ32WVKVRAVCNFSM6AAAAABZ67U6SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRRGY3DMMZYGE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
> [image: zimbatm]*zimbatm* left a comment (numtide/treefmt-nix#328)
> <#328 (comment)>
>
> no worries. can you also file an upstream issue, so we can eventually
> remove the fix?
>
> —
> Reply to this email directly, view it on GitHub
> <#328 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABJDTJE3XKTDLRKYMCUAZ32WVKVRAVCNFSM6AAAAABZ67U6SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRRGY3DMMZYGE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
or did you mean something else? |
zimbatm
reviewed
Apr 3, 2025
yes that's it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i was a little too fast yesterday. it looks like sql-formatter does not support multi file input. this fixes it.