cantata-dynamic: use new cache location #73
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Cantata 2 the cache location was
${XDG_CACHE_HOME}/cantatawith a lower casec. Cantata 3 uses${XDG_CACHE_HOME}/Cantatawith an upper caseCdue to the migration of configuration and data paths. Thecantata-dynamicperl script was not updated to reflect this change, which causes dynamic playlists to stop working.On systems that migrated from v2 to v3 the
cantata-dynamicscript will just forever use the last used playlist of v2. Not even stopping the playlist is possible once started because it depends on the current state which will never be updated. On systems that didn't have v2 installed prior the behavior is unknown I would assume. At worst, dynamic playlists just don't work at all.This PR updates the cache location in the perl script.
There is a code path for macOS in the script which points to
${HOME}/Library/Caches/cantata/cantata/dynamic. I don't have access to a macOS machine, but from guessing how Qt works this path probably needs to be updated too. A macOS user needs to confirm the correct cache location please.Fixes #47