-
Notifications
You must be signed in to change notification settings - Fork 955
Implemented new mDNS feature (POC) #2940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Gianla
wants to merge
18
commits into
ntop:dev
Choose a base branch
from
Gianla:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gianla
commented
Aug 10, 2025
IvanNardi
reviewed
Aug 11, 2025
IvanNardi
reviewed
Aug 11, 2025
Gianla
commented
Aug 12, 2025
IvanNardi
reviewed
Sep 15, 2025
IvanNardi
reviewed
Sep 15, 2025
@Gianla, I removed another include |
This comment has been minimized.
This comment has been minimized.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept for a patch implementing this feature.
This patch extended
ndpi_mdns_rsp_entry
with additional useful data and uses it to enhancendpi_flow_struct
.Some points:
ndpiReader.c
as well, though the formatting may not be ideal; I’m open to suggestions for improvements.dns.c
could potentially apply to standard DNS, but for now all modifications are guarded by theproto->master_protocol == NDPI_PROTOCOL_MDNS
condition;Right now I updated as many tests as I could, except forDONE. Looks like opening it to update a test (n. 196) corrupted the entire file, so the/tests/pcap/fuzz-2006-06-26-2594.pcap
. Probably due to thendpi_grab_dns_name()
update, it still gives some problems with text format. After a lot of time debugging it, I can't understand what's wrong with it. Any suggestion about it is appreciated.diff
never matched.Duplicate checks are currently not implemented, but they can be easily added above the newDONEadd_to_mdns_metadata()
function if needed.set_risk
should be used, so I have currently marked them as "TODO". I believe this is an important point that would benefit from further discussion with the core developers to determine the best approach.If and when all changes for answer records will be approved, I'll be ready to extend it also for additional records since as the approach is basically the same.
If the format is okay, I will also update the serializer.