-
Notifications
You must be signed in to change notification settings - Fork 46
ir: move config options out of top level #3619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
End-rey
wants to merge
6
commits into
master
Choose a base branch
from
3361-move-fschain_autodeploy-out-of-top-level
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fce1dad
ir: set config defaults directly
End-rey f3b4e34
ir: move `fschain_autodeploy` out of top level
End-rey 8022633
ir: move `without_mainnet` into `mainnet.enabled`
End-rey a88693c
ir: move `governance.disable` into `mainnet.disable_governance_sync`
End-rey bd7eb07
ir: move `fee.main_chain` into `mainnet.extra_fee`
End-rey 0c9d9d1
ir: move `contracts` into `mainnet.contracts`
End-rey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -192,7 +192,8 @@ func TestCheckForUnknownFieldsExample(t *testing.T) { | |
"wss://sidechain2.fs.neo.org:30333/ws", | ||
}, | ||
}, | ||
Validators: validators, | ||
DisableAutodeploy: true, | ||
Validators: validators, | ||
Consensus: config.Consensus{ | ||
Magic: 15405, | ||
Committee: committee, | ||
|
@@ -248,17 +249,25 @@ func TestCheckForUnknownFieldsExample(t *testing.T) { | |
RemoveUntraceableBlocks: false, | ||
P2PNotaryRequestPayloadPoolSize: 100, | ||
}}, | ||
FSChainAutodeploy: true, | ||
NNS: config.NNS{ | ||
SystemEmail: "[email protected]", | ||
}, | ||
Mainnet: config.BasicChain{ | ||
DialTimeout: time.Minute, | ||
ReconnectionsNumber: 5, | ||
ReconnectionsDelay: 5 * time.Second, | ||
Endpoints: []string{ | ||
"wss://mainchain1.fs.neo.org:30333/ws", | ||
"wss://mainchain.fs.neo.org:30333/ws", | ||
Mainnet: config.Mainnet{ | ||
Enabled: false, | ||
DisableGovernanceSync: false, | ||
ExtraFee: 50000000, | ||
Contracts: config.Contracts{ | ||
NeoFS: "ee3dee6d05dc79c24a5b8f6985e10d68b7cacc62", | ||
Processing: "597f5894867113a41e192801709c02497f611de8", | ||
}, | ||
BasicChain: config.BasicChain{ | ||
DialTimeout: time.Minute, | ||
ReconnectionsNumber: 5, | ||
ReconnectionsDelay: 5 * time.Second, | ||
Endpoints: []string{ | ||
"wss://mainchain1.fs.neo.org:30333/ws", | ||
"wss://mainchain.fs.neo.org:30333/ws", | ||
}, | ||
}, | ||
}, | ||
Control: config.Control{ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,7 @@ wallet: | |
without_mainnet: false # Run application in single chain environment without mainchain | ||
|
||
fschain: | ||
disable_autodeploy: true # Optional flag to disable auto-deployment procedure of the FS chain; defaults to 'false' | ||
dial_timeout: 1m # Timeout for RPC client connection to sidechain | ||
reconnections_number: 5 # number of reconnection attempts | ||
reconnections_delay: 5s # time delay b/w reconnection attempts | ||
|
@@ -109,15 +110,23 @@ fschain: | |
p2p_notary_request_payload_pool_size: 100 # Optional size of the node's P2P Notary request payloads memory pool. | ||
# Defaults to 1000. Must be unsigned integer in range [1:2147483647]. | ||
|
||
fschain_autodeploy: true # Optional flag to run auto-deployment procedure of the FS chain. By default, | ||
# the chain is expected to be deployed/updated in the background (e.g. via NeoFS ADM tool). | ||
fschain_autodeploy: false # Optional flag to run auto-deployment procedure of the FS chain. By default, 'true'. | ||
# If set, must be 'true' or 'false'. | ||
|
||
nns: # Optional configuration of the NNS domains processed during the FS chain deployment | ||
system_email: [email protected] # Optional e-mail to be assigned to the registered NNS domains. | ||
# Defaults to '[email protected]' | ||
|
||
mainnet: | ||
enabled: false # Enable connection to mainchain; by default, 'false', run application in single chain environment | ||
# without mainchain; value revert deprecated 'without_mainnet' | ||
disable_governance_sync: false # Disable synchronization of sidechain committee and mainchain role management contract; | ||
# ignore if mainchain is disabled; same as 'governance.disable' | ||
extra_fee: 50000000 # Fixed8 value of extra GAS fee for mainchain contract invocation; ignore if notary is enabled in mainchain; | ||
# same as 'fee.main_chain' | ||
contracts: # same as 'contracts' | ||
neofs: ee3dee6d05dc79c24a5b8f6985e10d68b7cacc62 # Address of NeoFS contract in mainchain; ignore if mainchain is disabled | ||
processing: 597f5894867113a41e192801709c02497f611de8 # Address of processing contract in mainchain; ignore if mainchain is disabled | ||
dial_timeout: 1m # Timeout for RPC client connection to mainchain; ignore if mainchain is disabled | ||
reconnections_number: 5 # number of reconnection attempts | ||
reconnections_delay: 5s # time delay b/w reconnection attempts | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.