New flag for VirtualKubernetesCluster controller: --node-selector-label #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating VirtualKubernetesClusters especially, it will sometimes be useful to limit the nodes used by the vCluster, with a node selector. The setting `fromHost.nodes.selector.labels` both limits which nodes appear from inside the vcluster, and which nodes pods can be scheduled on. I've represented this as a flag `--node-selector-label` -- label because the _value_ is going to be particular to the vcluster. It has a counterpart in the Helm chart values.yaml.
squaremo
force-pushed
the
vkc-node-selector
branch
from
95abc24 to
6997617
Compare
squaremo
commented
May 19, 2025
| @@ -135,7 +134,8 @@ func (o *Options) AddFlags(f *pflag.FlagSet) { | |||
| o.regionOptions.AddFlags(f) | |||
| o.clientOptions.AddFlags(f) | |||
|
|
|||
| f.StringVar(&o.domain, "virtual-kubernetes-cluster-domain", "virtual-kubernetes.example.com", "DNS domain for vclusters to be hosts of.") | |||
| f.StringVar(&o.provisionerOptions.Domain, "virtual-kubernetes-cluster-domain", "virtual-kubernetes.example.com", "DNS domain for vclusters to be hosts of.") | |||
| f.StringVar(&o.provisionerOptions.NodeSelectorLabel, "node-selector-label", "", "Label to use for vCluster node selectors (with the value of the vcluster name).") | |||
There was a problem hiding this comment.
Suggested change
| f.StringVar(&o.provisionerOptions.NodeSelectorLabel, "node-selector-label", "", "Label to use for vCluster node selectors (with the value of the vcluster name).") | |
| f.StringVar(&o.provisionerOptions.NodeSelectorLabel, "node-selector-label", "", "Label to use for vCluster node selectors (will be given the value of the vcluster name, in the selector).") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating VirtualKubernetesClusters especially, it will sometimes be useful to limit the nodes used by the vCluster, with a node selector. The setting
fromHost.nodes.selector.labelsboth limits which nodes appear from inside the vcluster, and which nodes pods can be scheduled on.I've represented this as a flag
--node-selector-label-- label because the value is going to be particular to the vcluster. It has a counterpart in the Helm chart values.yaml.